From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "joe@perches.com" <joe@perches.com>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"axboe@fb.com" <axboe@fb.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros
Date: Mon, 22 Jan 2018 20:42:04 +0000 [thread overview]
Message-ID: <1516653723.2545.37.camel@wdc.com> (raw)
In-Reply-To: <1516652629.8378.14.camel@perches.com>
On Mon, 2018-01-22 at 12:23 -0800, Joe Perches wrote:
> On Mon, 2018-01-22 at 08:53 +0100, Johannes Thumshirn wrote:
> > Use pr_debug instead of hand crafted macros. This way it is not needed to
> > re-compile the kernel to enable bsg debug outputs and it's possible to
> > selectively enable specific prints.
>
> Perhaps better to use
>
> #define bsg_dbg(bd, fmt, ...) \
> pr_debug(bd->name, fmt, ##__VA_ARGS__)
Hello Joe,
Why do you think that would be better?
Thanks,
Bart.
next prev parent reply other threads:[~2018-01-22 20:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 7:53 [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros Johannes Thumshirn
2018-01-22 16:33 ` Bart Van Assche
2018-01-22 20:23 ` Joe Perches
2018-01-22 20:42 ` Bart Van Assche [this message]
2018-01-22 21:04 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516653723.2545.37.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@fb.com \
--cc=joe@perches.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox