* [PATCH net] selftests: net: ip_local_port_range: define IPPROTO_MPTCP
@ 2024-02-09 13:25 Maxim Galaganov
2024-02-09 13:57 ` Matthieu Baerts
2024-02-13 1:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Maxim Galaganov @ 2024-02-09 13:25 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Shuah Khan, Mat Martineau, Maxim Galaganov, Matthieu Baerts
Cc: Linux Kernel Functional Testing, netdev, linux-kselftest,
linux-kernel
Older glibc's netinet/in.h may leave IPPROTO_MPTCP undefined when
building ip_local_port_range.c, that leads to "error: use of undeclared
identifier 'IPPROTO_MPTCP'".
Define IPPROTO_MPTCP in such cases, just like in other MPTCP selftests.
Fixes: 122db5e3634b ("selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE")
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Closes: https://lore.kernel.org/netdev/CA+G9fYvGO5q4o_Td_kyQgYieXWKw6ktMa-Q0sBu6S-0y3w2aEQ@mail.gmail.com/
Signed-off-by: Maxim Galaganov <max@internet.ru>
---
tools/testing/selftests/net/ip_local_port_range.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/testing/selftests/net/ip_local_port_range.c b/tools/testing/selftests/net/ip_local_port_range.c
index 0f217a1cc837..6ebd58869a63 100644
--- a/tools/testing/selftests/net/ip_local_port_range.c
+++ b/tools/testing/selftests/net/ip_local_port_range.c
@@ -16,6 +16,10 @@
#define IP_LOCAL_PORT_RANGE 51
#endif
+#ifndef IPPROTO_MPTCP
+#define IPPROTO_MPTCP 262
+#endif
+
static __u32 pack_port_range(__u16 lo, __u16 hi)
{
return (hi << 16) | (lo << 0);
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] selftests: net: ip_local_port_range: define IPPROTO_MPTCP
2024-02-09 13:25 [PATCH net] selftests: net: ip_local_port_range: define IPPROTO_MPTCP Maxim Galaganov
@ 2024-02-09 13:57 ` Matthieu Baerts
2024-02-12 18:39 ` Naresh Kamboju
2024-02-13 1:10 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Matthieu Baerts @ 2024-02-09 13:57 UTC (permalink / raw)
To: Maxim Galaganov, Naresh Kamboju
Cc: Linux Kernel Functional Testing, netdev, linux-kselftest,
linux-kernel, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Shuah Khan, Mat Martineau
Hi Maxim, Naresh,
On 09/02/2024 14:25, Maxim Galaganov wrote:
> Older glibc's netinet/in.h may leave IPPROTO_MPTCP undefined when
> building ip_local_port_range.c, that leads to "error: use of undeclared
> identifier 'IPPROTO_MPTCP'".
>
> Define IPPROTO_MPTCP in such cases, just like in other MPTCP selftests.
>
> Fixes: 122db5e3634b ("selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE")
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Closes: https://lore.kernel.org/netdev/CA+G9fYvGO5q4o_Td_kyQgYieXWKw6ktMa-Q0sBu6S-0y3w2aEQ@mail.gmail.com/
> Signed-off-by: Maxim Galaganov <max@internet.ru>
Thank you both for the fix and the bug report!
Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] selftests: net: ip_local_port_range: define IPPROTO_MPTCP
2024-02-09 13:57 ` Matthieu Baerts
@ 2024-02-12 18:39 ` Naresh Kamboju
0 siblings, 0 replies; 4+ messages in thread
From: Naresh Kamboju @ 2024-02-12 18:39 UTC (permalink / raw)
To: Matthieu Baerts
Cc: Maxim Galaganov, Linux Kernel Functional Testing, netdev,
linux-kselftest, linux-kernel, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Shuah Khan, Mat Martineau
On Fri, 9 Feb 2024 at 19:27, Matthieu Baerts <matttbe@kernel.org> wrote:
>
> Hi Maxim, Naresh,
>
> On 09/02/2024 14:25, Maxim Galaganov wrote:
> > Older glibc's netinet/in.h may leave IPPROTO_MPTCP undefined when
> > building ip_local_port_range.c, that leads to "error: use of undeclared
> > identifier 'IPPROTO_MPTCP'".
> >
> > Define IPPROTO_MPTCP in such cases, just like in other MPTCP selftests.
> >
> > Fixes: 122db5e3634b ("selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE")
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > Closes: https://lore.kernel.org/netdev/CA+G9fYvGO5q4o_Td_kyQgYieXWKw6ktMa-Q0sBu6S-0y3w2aEQ@mail.gmail.com/
> > Signed-off-by: Maxim Galaganov <max@internet.ru>
>
> Thank you both for the fix and the bug report!
>
> Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] selftests: net: ip_local_port_range: define IPPROTO_MPTCP
2024-02-09 13:25 [PATCH net] selftests: net: ip_local_port_range: define IPPROTO_MPTCP Maxim Galaganov
2024-02-09 13:57 ` Matthieu Baerts
@ 2024-02-13 1:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-13 1:10 UTC (permalink / raw)
To: Maxim Galaganov
Cc: davem, edumazet, kuba, pabeni, shuah, martineau, matttbe, lkft,
netdev, linux-kselftest, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 9 Feb 2024 16:25:11 +0300 you wrote:
> Older glibc's netinet/in.h may leave IPPROTO_MPTCP undefined when
> building ip_local_port_range.c, that leads to "error: use of undeclared
> identifier 'IPPROTO_MPTCP'".
>
> Define IPPROTO_MPTCP in such cases, just like in other MPTCP selftests.
>
> Fixes: 122db5e3634b ("selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE")
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Closes: https://lore.kernel.org/netdev/CA+G9fYvGO5q4o_Td_kyQgYieXWKw6ktMa-Q0sBu6S-0y3w2aEQ@mail.gmail.com/
> Signed-off-by: Maxim Galaganov <max@internet.ru>
>
> [...]
Here is the summary with links:
- [net] selftests: net: ip_local_port_range: define IPPROTO_MPTCP
https://git.kernel.org/netdev/net/c/c2b3ec36b422
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-13 1:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-09 13:25 [PATCH net] selftests: net: ip_local_port_range: define IPPROTO_MPTCP Maxim Galaganov
2024-02-09 13:57 ` Matthieu Baerts
2024-02-12 18:39 ` Naresh Kamboju
2024-02-13 1:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox