[PATCH net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page_fini()

[PATCH net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page_fini()

[Yue Haibing]

ethtool_cmis_page_fini() is declared but never implemented.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 net/ethtool/cmis.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ethtool/cmis.h b/net/ethtool/cmis.h
index e71cc3e1b7eb..3e7c293af78c 100644
--- a/net/ethtool/cmis.h
+++ b/net/ethtool/cmis.h
@@ -108,7 +108,6 @@ void ethtool_cmis_cdb_check_completion_flag(u8 cmis_rev, u8 *flags);
 
 void ethtool_cmis_page_init(struct ethtool_module_eeprom *page_data,
 			    u8 page, u32 offset, u32 length);
-void ethtool_cmis_page_fini(struct ethtool_module_eeprom *page_data);
 
 struct ethtool_cmis_cdb *
 ethtool_cmis_cdb_init(struct net_device *dev,
-- 
2.34.1

RE: [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page_fini()

[Danielle Ratson]

> From: Yue Haibing <yuehaibing@huawei.com>
> Sent: Saturday, 3 August 2024 14:22
> To: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; Danielle Ratson <danieller@nvidia.com>;
> yuehaibing@huawei.com
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration
> ethtool_cmis_page_fini()
> 
> ethtool_cmis_page_fini() is declared but never implemented.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  net/ethtool/cmis.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/ethtool/cmis.h b/net/ethtool/cmis.h index
> e71cc3e1b7eb..3e7c293af78c 100644
> --- a/net/ethtool/cmis.h
> +++ b/net/ethtool/cmis.h
> @@ -108,7 +108,6 @@ void ethtool_cmis_cdb_check_completion_flag(u8
> cmis_rev, u8 *flags);
> 
>  void ethtool_cmis_page_init(struct ethtool_module_eeprom *page_data,
>  			    u8 page, u32 offset, u32 length); -void
> ethtool_cmis_page_fini(struct ethtool_module_eeprom *page_data);
> 
>  struct ethtool_cmis_cdb *
>  ethtool_cmis_cdb_init(struct net_device *dev,
> --
> 2.34.1
> 

Reviewed-by: Danielle Ratson <danieller@nvidia.com>

Thanks!

Re: [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page_fini()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 3 Aug 2024 19:22:13 +0800 you wrote:
> ethtool_cmis_page_fini() is declared but never implemented.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  net/ethtool/cmis.h | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - [net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page_fini()
    https://git.kernel.org/netdev/net-next/c/edfa53dd617f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html