* [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page_fini()
@ 2024-08-03 11:22 Yue Haibing
2024-08-04 8:08 ` Danielle Ratson
2024-08-06 20:28 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2024-08-03 11:22 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, danieller, yuehaibing; +Cc: netdev, linux-kernel
ethtool_cmis_page_fini() is declared but never implemented.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
net/ethtool/cmis.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/ethtool/cmis.h b/net/ethtool/cmis.h
index e71cc3e1b7eb..3e7c293af78c 100644
--- a/net/ethtool/cmis.h
+++ b/net/ethtool/cmis.h
@@ -108,7 +108,6 @@ void ethtool_cmis_cdb_check_completion_flag(u8 cmis_rev, u8 *flags);
void ethtool_cmis_page_init(struct ethtool_module_eeprom *page_data,
u8 page, u32 offset, u32 length);
-void ethtool_cmis_page_fini(struct ethtool_module_eeprom *page_data);
struct ethtool_cmis_cdb *
ethtool_cmis_cdb_init(struct net_device *dev,
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page_fini()
2024-08-03 11:22 [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page_fini() Yue Haibing
@ 2024-08-04 8:08 ` Danielle Ratson
2024-08-06 20:28 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Danielle Ratson @ 2024-08-04 8:08 UTC (permalink / raw)
To: Yue Haibing, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
> From: Yue Haibing <yuehaibing@huawei.com>
> Sent: Saturday, 3 August 2024 14:22
> To: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; Danielle Ratson <danieller@nvidia.com>;
> yuehaibing@huawei.com
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration
> ethtool_cmis_page_fini()
>
> ethtool_cmis_page_fini() is declared but never implemented.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> net/ethtool/cmis.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/ethtool/cmis.h b/net/ethtool/cmis.h index
> e71cc3e1b7eb..3e7c293af78c 100644
> --- a/net/ethtool/cmis.h
> +++ b/net/ethtool/cmis.h
> @@ -108,7 +108,6 @@ void ethtool_cmis_cdb_check_completion_flag(u8
> cmis_rev, u8 *flags);
>
> void ethtool_cmis_page_init(struct ethtool_module_eeprom *page_data,
> u8 page, u32 offset, u32 length); -void
> ethtool_cmis_page_fini(struct ethtool_module_eeprom *page_data);
>
> struct ethtool_cmis_cdb *
> ethtool_cmis_cdb_init(struct net_device *dev,
> --
> 2.34.1
>
Reviewed-by: Danielle Ratson <danieller@nvidia.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page_fini()
2024-08-03 11:22 [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page_fini() Yue Haibing
2024-08-04 8:08 ` Danielle Ratson
@ 2024-08-06 20:28 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-06 20:28 UTC (permalink / raw)
To: Yue Haibing
Cc: davem, edumazet, kuba, pabeni, danieller, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 3 Aug 2024 19:22:13 +0800 you wrote:
> ethtool_cmis_page_fini() is declared but never implemented.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> net/ethtool/cmis.h | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page_fini()
https://git.kernel.org/netdev/net-next/c/edfa53dd617f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-06 20:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-03 11:22 [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page_fini() Yue Haibing
2024-08-04 8:08 ` Danielle Ratson
2024-08-06 20:28 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox