* [PATCH] riscv: remove redundant CMDLINE_FORCE check
@ 2025-01-13 16:30 Zixian Zeng
2025-02-26 15:16 ` Alexandre Ghiti
2025-03-27 3:24 ` patchwork-bot+linux-riscv
0 siblings, 2 replies; 3+ messages in thread
From: Zixian Zeng @ 2025-01-13 16:30 UTC (permalink / raw)
To: Paul Walmsley, Palmer Dabbelt, Albert Ou
Cc: linux-riscv, linux-kernel, Zixian Zeng
Drop redundant CMDLINE_FORCE check as it's already done in
function early_init_dt_scan_chosen().
Signed-off-by: Zixian Zeng <sycamoremoon376@gmail.com>
---
---
arch/riscv/kernel/setup.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
index 45010e71df86ce40f99fabf03103a49ad1041f3d..a08a8409aab01d504d3ad975fbf9c66c02992713 100644
--- a/arch/riscv/kernel/setup.c
+++ b/arch/riscv/kernel/setup.c
@@ -237,11 +237,6 @@ static void __init parse_dtb(void)
} else {
pr_err("No DTB passed to the kernel\n");
}
-
-#ifdef CONFIG_CMDLINE_FORCE
- strscpy(boot_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
- pr_info("Forcing kernel command line to: %s\n", boot_command_line);
-#endif
}
#if defined(CONFIG_RISCV_COMBO_SPINLOCKS)
---
base-commit: fa47906ff358a5865b7be2356a5a1d1e58dd17d8
change-id: 20250113-rebund-25d469c1c4d5
Best regards,
--
Zixian Zeng <sycamoremoon376@gmail.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: remove redundant CMDLINE_FORCE check
2025-01-13 16:30 [PATCH] riscv: remove redundant CMDLINE_FORCE check Zixian Zeng
@ 2025-02-26 15:16 ` Alexandre Ghiti
2025-03-27 3:24 ` patchwork-bot+linux-riscv
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Ghiti @ 2025-02-26 15:16 UTC (permalink / raw)
To: Zixian Zeng, Paul Walmsley, Palmer Dabbelt, Albert Ou
Cc: linux-riscv, linux-kernel
Hi Zixian,
On 13/01/2025 17:30, Zixian Zeng wrote:
> Drop redundant CMDLINE_FORCE check as it's already done in
> function early_init_dt_scan_chosen().
>
> Signed-off-by: Zixian Zeng <sycamoremoon376@gmail.com>
> ---
> ---
> arch/riscv/kernel/setup.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
> index 45010e71df86ce40f99fabf03103a49ad1041f3d..a08a8409aab01d504d3ad975fbf9c66c02992713 100644
> --- a/arch/riscv/kernel/setup.c
> +++ b/arch/riscv/kernel/setup.c
> @@ -237,11 +237,6 @@ static void __init parse_dtb(void)
> } else {
> pr_err("No DTB passed to the kernel\n");
> }
> -
> -#ifdef CONFIG_CMDLINE_FORCE
> - strscpy(boot_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> - pr_info("Forcing kernel command line to: %s\n", boot_command_line);
> -#endif
> }
>
> #if defined(CONFIG_RISCV_COMBO_SPINLOCKS)
>
> ---
> base-commit: fa47906ff358a5865b7be2356a5a1d1e58dd17d8
> change-id: 20250113-rebund-25d469c1c4d5
>
> Best regards,
We lose the pr_info() but to me that's not a problem, so:
Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Thanks,
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: remove redundant CMDLINE_FORCE check
2025-01-13 16:30 [PATCH] riscv: remove redundant CMDLINE_FORCE check Zixian Zeng
2025-02-26 15:16 ` Alexandre Ghiti
@ 2025-03-27 3:24 ` patchwork-bot+linux-riscv
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-riscv @ 2025-03-27 3:24 UTC (permalink / raw)
To: Zixian Zeng; +Cc: linux-riscv, paul.walmsley, palmer, aou, linux-kernel
Hello:
This patch was applied to riscv/linux.git (for-next)
by Alexandre Ghiti <alexghiti@rivosinc.com>:
On Tue, 14 Jan 2025 00:30:20 +0800 you wrote:
> Drop redundant CMDLINE_FORCE check as it's already done in
> function early_init_dt_scan_chosen().
>
> Signed-off-by: Zixian Zeng <sycamoremoon376@gmail.com>
> ---
> ---
> arch/riscv/kernel/setup.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> [...]
Here is the summary with links:
- riscv: remove redundant CMDLINE_FORCE check
https://git.kernel.org/riscv/c/eac5b138814a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-27 3:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-13 16:30 [PATCH] riscv: remove redundant CMDLINE_FORCE check Zixian Zeng
2025-02-26 15:16 ` Alexandre Ghiti
2025-03-27 3:24 ` patchwork-bot+linux-riscv
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).