[PATCH] riscv: remove redundant CMDLINE_FORCE check

[PATCH] riscv: remove redundant CMDLINE_FORCE check

[Zixian Zeng]

Drop redundant CMDLINE_FORCE check as it's already done in
function early_init_dt_scan_chosen().

Signed-off-by: Zixian Zeng <sycamoremoon376@gmail.com>
---
---
 arch/riscv/kernel/setup.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
index 45010e71df86ce40f99fabf03103a49ad1041f3d..a08a8409aab01d504d3ad975fbf9c66c02992713 100644
--- a/arch/riscv/kernel/setup.c
+++ b/arch/riscv/kernel/setup.c
@@ -237,11 +237,6 @@ static void __init parse_dtb(void)
 	} else {
 		pr_err("No DTB passed to the kernel\n");
 	}
-
-#ifdef CONFIG_CMDLINE_FORCE
-	strscpy(boot_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
-	pr_info("Forcing kernel command line to: %s\n", boot_command_line);
-#endif
 }
 
 #if defined(CONFIG_RISCV_COMBO_SPINLOCKS)

---
base-commit: fa47906ff358a5865b7be2356a5a1d1e58dd17d8
change-id: 20250113-rebund-25d469c1c4d5

Best regards,
-- 
Zixian Zeng <sycamoremoon376@gmail.com>

Re: [PATCH] riscv: remove redundant CMDLINE_FORCE check

[Alexandre Ghiti]

Hi Zixian,

On 13/01/2025 17:30, Zixian Zeng wrote:
> Drop redundant CMDLINE_FORCE check as it's already done in
> function early_init_dt_scan_chosen().
>
> Signed-off-by: Zixian Zeng <sycamoremoon376@gmail.com>
> ---
> ---
>   arch/riscv/kernel/setup.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
> index 45010e71df86ce40f99fabf03103a49ad1041f3d..a08a8409aab01d504d3ad975fbf9c66c02992713 100644
> --- a/arch/riscv/kernel/setup.c
> +++ b/arch/riscv/kernel/setup.c
> @@ -237,11 +237,6 @@ static void __init parse_dtb(void)
>   	} else {
>   		pr_err("No DTB passed to the kernel\n");
>   	}
> -
> -#ifdef CONFIG_CMDLINE_FORCE
> -	strscpy(boot_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> -	pr_info("Forcing kernel command line to: %s\n", boot_command_line);
> -#endif
>   }
>   
>   #if defined(CONFIG_RISCV_COMBO_SPINLOCKS)
>
> ---
> base-commit: fa47906ff358a5865b7be2356a5a1d1e58dd17d8
> change-id: 20250113-rebund-25d469c1c4d5
>
> Best regards,


We lose the pr_info() but to me that's not a problem, so:

Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>

Thanks,

Alex

Re: [PATCH] riscv: remove redundant CMDLINE_FORCE check

[patchwork-bot+linux-riscv]

Hello:

This patch was applied to riscv/linux.git (for-next)
by Alexandre Ghiti <alexghiti@rivosinc.com>:

On Tue, 14 Jan 2025 00:30:20 +0800 you wrote:
> Drop redundant CMDLINE_FORCE check as it's already done in
> function early_init_dt_scan_chosen().
> 
> Signed-off-by: Zixian Zeng <sycamoremoon376@gmail.com>
> ---
> ---
>  arch/riscv/kernel/setup.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> [...]

Here is the summary with links:
  - riscv: remove redundant CMDLINE_FORCE check
    https://git.kernel.org/riscv/c/eac5b138814a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html