From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: CK Hu <ck.hu@mediatek.com>,
Rex-BC Chen <rex-bc.chen@mediatek.com>,
Singo Chang <singo.chang@mediatek.com>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH RESEND v3 0/9] Add gamma lut support for mt8195
Date: Thu, 27 Apr 2023 17:15:18 +0200 [thread overview]
Message-ID: <17525028-80bb-cd03-fbc9-b8ff65378517@collabora.com> (raw)
In-Reply-To: <c6a12ebc-99f1-855d-e366-e5a4833dc562@collabora.com>
Il 26/04/23 13:43, AngeloGioacchino Del Regno ha scritto:
> Il 12/09/22 03:29, Jason-JH.Lin ha scritto:
>> Since the gamma_set_common() function for previous SoC,
>> such as mt8173 and mt8183, is designed for 9bit-to-10bit
>> conversion.
>> mt8195 is using 10bit-to-12bit conversion, which is
>> not compatible with the previous function.
>>
>> Thus, need to update the function to fit the need of mt8195.
>
> Hello,
> can you please respin and fix this series on the latest linux-next?
>
> Besides, please test it carefully: as far as I can see, GNOME Night Light
> (or others) are not working on MT8195 (color temperature/ccorr).
> As for gamma itself, that's not working either; you can test it with a tool
> that will create a color profile by applying a new VCGT table, please look
> at [1] if you need tools.
>
> We can confirm that color correction works on at least MT8192 (colord), so
> it's MT8195 at fault.
>
> [1]: https://github.com/zb3/gnome-gamma-tool
>
Nevermind. I've actually fixed this code and refactored it a bit as well.
I'll push my own version soon. No action required.
Regards,
Angelo
next prev parent reply other threads:[~2023-04-27 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220912013006.27541-1-jason-jh.lin@mediatek.com>
[not found] ` <20220912013006.27541-4-jason-jh.lin@mediatek.com>
[not found] ` <44d19c4ea29bdbf3a07890ed25fd637f8805b6c6.camel@mediatek.com>
2022-09-14 1:10 ` [PATCH RESEND v3 3/9] drm/mediatek: Adjust mtk_drm_gamma_set_common parameters Jason-JH Lin
[not found] ` <20220912013006.27541-5-jason-jh.lin@mediatek.com>
[not found] ` <e1945785da7c56bbb7fe94926c39fc6c3593cdb0.camel@mediatek.com>
2022-09-14 1:14 ` [PATCH RESEND v3 4/9] drm/mediatek: Add gamma support different lut_size for other SoC Jason-JH Lin
[not found] ` <20220912013006.27541-6-jason-jh.lin@mediatek.com>
[not found] ` <b740f81d62ce73e08a2a43637b4f951298b1c28a.camel@mediatek.com>
2022-09-14 1:17 ` [PATCH RESEND v3 5/9] drm/mediatek: Add gamma support different lut_bits " Jason-JH Lin
[not found] ` <20220912013006.27541-9-jason-jh.lin@mediatek.com>
[not found] ` <ecdb209437e78b3273374ef963fd2c5c64ba88fd.camel@mediatek.com>
2022-09-14 1:26 ` [PATCH RESEND v3 8/9] drm/mediatek: Add clear RELAY_MODE bit to set gamma Jason-JH Lin
[not found] ` <20220912013006.27541-2-jason-jh.lin@mediatek.com>
2022-09-18 9:59 ` [PATCH RESEND v3 1/9] dt-bindings: mediatek: modify item formatting for gamma Krzysztof Kozlowski
[not found] ` <20220912013006.27541-3-jason-jh.lin@mediatek.com>
2022-09-18 9:59 ` [PATCH RESEND v3 2/9] dt-bindings: mediatek: Add gamma compatible for mt8195 Krzysztof Kozlowski
2023-04-26 11:43 ` [PATCH RESEND v3 0/9] Add gamma lut support " AngeloGioacchino Del Regno
2023-04-27 15:15 ` AngeloGioacchino Del Regno [this message]
2023-04-28 6:45 ` Jason-JH Lin (林睿祥)
[not found] ` <20220912013006.27541-7-jason-jh.lin@mediatek.com>
[not found] ` <3c67e742bdb06e55ba170a0a6dc79e6f6833c0e7.camel@mediatek.com>
2022-09-14 1:28 ` [PATCH RESEND v3 6/9] drm/mediatek: Add gamma support different bank_size for other SoC Jason-JH Lin
2023-04-26 12:06 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17525028-80bb-cd03-fbc9-b8ff65378517@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-jh.lin@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=singo.chang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox