public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: Ben Horgan <ben.horgan@arm.com>, <linux-kernel@vger.kernel.org>
Cc: <tony.luck@intel.com>, <Dave.Martin@arm.com>,
	<james.morse@arm.com>, <babu.moger@amd.com>, <tglx@kernel.org>,
	<mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, <hpa@zytor.com>, <fenghuay@nvidia.com>,
	<tan.shaopeng@fujitsu.com>
Subject: Re: [PATCH v5 5/7] fs/resctrl: Continue counter allocation after failure
Date: Mon, 4 May 2026 09:01:31 -0700	[thread overview]
Message-ID: <176dd142-654d-4d68-8b45-fd5aa2c9f68c@intel.com> (raw)
In-Reply-To: <20260428130422.2287302-6-ben.horgan@arm.com>

Hi Ben,

On 4/28/26 6:04 AM, Ben Horgan wrote:
> In mbm_event mode, with mbm_assign_on_mkdir set to 1, when a user creates a
> new CTRL_MON or MON group resctrl attempts to allocate counters for each of
> the supported MBM events on each resctrl domain. As counters are limited,
> such allocation may fail and when it does counter allocations for the
> remaining domains are skipped even if the domains have available counters.
> 
> Since a counter allocation failure may result in counter allocation being
> skipped on other domains the user needs to view the resource group's
> mbm_L3_assignments files to get an accurate view of counter assignment in a

nit: files -> file

> new resource group and then manually create counters in the skipped domains
> with available counters.
> 
> Writes to mbm_L3_assignments using the wildcard format, <event>:*=e, also
> skip counter allocation in other domains after a counter allocation
> failure.
> 
> When handling a request to create counters in all domains it is unnecessary
> for a counter allocation in one domain to prevent counter allocation in
> other domains. Always attempt to allocate all the counters requested.
> 
> Signed-off-by: Ben Horgan <ben.horgan@arm.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette

  reply	other threads:[~2026-05-04 16:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 13:04 [PATCH v5 0/7] x86,fs/resctrl: Pave the way for MPAM counter assignment Ben Horgan
2026-04-28 13:04 ` [PATCH v5 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs() Ben Horgan
2026-05-04 15:59   ` Reinette Chatre
2026-04-28 13:04 ` [PATCH v5 2/7] x86,fs/resctrl: Create 'event_filter' files read only if they're not configurable Ben Horgan
2026-05-04 15:59   ` Reinette Chatre
2026-04-28 13:04 ` [PATCH v5 3/7] fs/resctrl: Disallow the software controller when MBM counters are assignable Ben Horgan
2026-05-04 16:01   ` Reinette Chatre
2026-05-05  9:34     ` Ben Horgan
2026-05-05 10:20       ` Ben Horgan
2026-05-05 15:21         ` Reinette Chatre
2026-05-05 15:51           ` Ben Horgan
2026-04-28 13:04 ` [PATCH v5 4/7] fs/resctrl: Add monitor property 'mbm_cntr_assign_fixed' Ben Horgan
2026-05-04 16:01   ` Reinette Chatre
2026-04-28 13:04 ` [PATCH v5 5/7] fs/resctrl: Continue counter allocation after failure Ben Horgan
2026-05-04 16:01   ` Reinette Chatre [this message]
2026-04-28 13:04 ` [PATCH v5 6/7] fs/resctrl: Document that automatic counter assignment is best effort Ben Horgan
2026-05-04 16:01   ` Reinette Chatre
2026-04-28 13:04 ` [PATCH v5 7/7] fs/resctrl: Document tasks file behaviour for task id 0 and idle tasks Ben Horgan
2026-05-04 16:02   ` Reinette Chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176dd142-654d-4d68-8b45-fd5aa2c9f68c@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=ben.horgan@arm.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghuay@nvidia.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tan.shaopeng@fujitsu.com \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox