public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Horgan <ben.horgan@arm.com>
To: linux-kernel@vger.kernel.org
Cc: tony.luck@intel.com, reinette.chatre@intel.com,
	Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com,
	tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	ben.horgan@arm.com, fenghuay@nvidia.com,
	tan.shaopeng@fujitsu.com
Subject: [PATCH v5 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs()
Date: Tue, 28 Apr 2026 14:04:16 +0100	[thread overview]
Message-ID: <20260428130422.2287302-2-ben.horgan@arm.com> (raw)
In-Reply-To: <20260428130422.2287302-1-ben.horgan@arm.com>

The error path in resctrl_mkdir_event_configs() is unnecessarily
complicated. Simplify it to just return directly on error.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Ben Horgan <ben.horgan@arm.com>
---
 fs/resctrl/rdtgroup.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
index 5dfdaa6f9d8f..fb6999178fe2 100644
--- a/fs/resctrl/rdtgroup.c
+++ b/fs/resctrl/rdtgroup.c
@@ -2333,20 +2333,19 @@ static int resctrl_mkdir_event_configs(struct rdt_resource *r, struct kernfs_nod
 		kn_subdir2 = kernfs_create_dir(kn_subdir, mevt->name, kn_subdir->mode, mevt);
 		if (IS_ERR(kn_subdir2)) {
 			ret = PTR_ERR(kn_subdir2);
-			goto out;
+			return ret;
 		}
 
 		ret = rdtgroup_kn_set_ugid(kn_subdir2);
 		if (ret)
-			goto out;
+			return ret;
 
 		ret = rdtgroup_add_files(kn_subdir2, RFTYPE_ASSIGN_CONFIG);
 		if (ret)
-			break;
+			return ret;
 	}
 
-out:
-	return ret;
+	return 0;
 }
 
 static int rdtgroup_mkdir_info_resdir(void *priv, char *name,
-- 
2.43.0


  reply	other threads:[~2026-04-28 13:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 13:04 [PATCH v5 0/7] x86,fs/resctrl: Pave the way for MPAM counter assignment Ben Horgan
2026-04-28 13:04 ` Ben Horgan [this message]
2026-05-04 15:59   ` [PATCH v5 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs() Reinette Chatre
2026-04-28 13:04 ` [PATCH v5 2/7] x86,fs/resctrl: Create 'event_filter' files read only if they're not configurable Ben Horgan
2026-05-04 15:59   ` Reinette Chatre
2026-04-28 13:04 ` [PATCH v5 3/7] fs/resctrl: Disallow the software controller when MBM counters are assignable Ben Horgan
2026-05-04 16:01   ` Reinette Chatre
2026-05-05  9:34     ` Ben Horgan
2026-05-05 10:20       ` Ben Horgan
2026-05-05 15:21         ` Reinette Chatre
2026-05-05 15:51           ` Ben Horgan
2026-04-28 13:04 ` [PATCH v5 4/7] fs/resctrl: Add monitor property 'mbm_cntr_assign_fixed' Ben Horgan
2026-05-04 16:01   ` Reinette Chatre
2026-04-28 13:04 ` [PATCH v5 5/7] fs/resctrl: Continue counter allocation after failure Ben Horgan
2026-05-04 16:01   ` Reinette Chatre
2026-04-28 13:04 ` [PATCH v5 6/7] fs/resctrl: Document that automatic counter assignment is best effort Ben Horgan
2026-05-04 16:01   ` Reinette Chatre
2026-04-28 13:04 ` [PATCH v5 7/7] fs/resctrl: Document tasks file behaviour for task id 0 and idle tasks Ben Horgan
2026-05-04 16:02   ` Reinette Chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260428130422.2287302-2-ben.horgan@arm.com \
    --to=ben.horgan@arm.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghuay@nvidia.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=tan.shaopeng@fujitsu.com \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox