* [PATCH] w1: fix timeout_us parameter description
@ 2016-08-08 13:52 Wei Yongjun
2016-08-09 22:54 ` Evgeniy Polyakov
2016-08-11 0:03 ` [PATCH v2] w1: fix typo in " Wei Yongjun
0 siblings, 2 replies; 6+ messages in thread
From: Wei Yongjun @ 2016-08-08 13:52 UTC (permalink / raw)
To: Evgeniy Polyakov, Greg Kroah-Hartman; +Cc: Wei Yongjun, linux-kernel
Fix 'timeout_us' parameter description.
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/w1/w1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index bb34362..e213c67 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -53,8 +53,8 @@ int w1_max_slave_ttl = 10;
module_param_named(timeout, w1_timeout, int, 0);
MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches");
module_param_named(timeout_us, w1_timeout_us, int, 0);
-MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
- " searches");
+MODULE_PARM_DESC(timeout_us,
+ "time in microseconds between automatic slave searches");
/* A search stops when w1_max_slave_count devices have been found in that
* search. The next search will start over and detect the same set of devices
* on a static 1-wire bus. Memory is not allocated based on this number, just
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] w1: fix timeout_us parameter description
2016-08-08 13:52 [PATCH] w1: fix timeout_us parameter description Wei Yongjun
@ 2016-08-09 22:54 ` Evgeniy Polyakov
2016-08-10 3:22 ` Wei Yongjun
2016-08-11 0:03 ` [PATCH v2] w1: fix typo in " Wei Yongjun
1 sibling, 1 reply; 6+ messages in thread
From: Evgeniy Polyakov @ 2016-08-09 22:54 UTC (permalink / raw)
To: Wei Yongjun, Greg Kroah-Hartman; +Cc: linux-kernel@vger.kernel.org
Hi
08.08.2016, 16:52, "Wei Yongjun" <weiyj.lk@gmail.com>:
> Fix 'timeout_us' parameter description.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
> ---
> drivers/w1/w1.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index bb34362..e213c67 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -53,8 +53,8 @@ int w1_max_slave_ttl = 10;
> module_param_named(timeout, w1_timeout, int, 0);
> MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches");
> module_param_named(timeout_us, w1_timeout_us, int, 0);
> -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
> - " searches");
> +MODULE_PARM_DESC(timeout_us,
> + "time in microseconds between automatic slave searches");
I believe there will be no harm to put it to on one line, even if it crosses some obscure very-long-line rule
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] w1: fix timeout_us parameter description
2016-08-09 22:54 ` Evgeniy Polyakov
@ 2016-08-10 3:22 ` Wei Yongjun
2016-08-10 20:00 ` Evgeniy Polyakov
0 siblings, 1 reply; 6+ messages in thread
From: Wei Yongjun @ 2016-08-10 3:22 UTC (permalink / raw)
To: Evgeniy Polyakov, Greg Kroah-Hartman; +Cc: linux-kernel@vger.kernel.org
Hi
On 08/10/2016 06:54 AM, Evgeniy Polyakov wrote:
> Hi
>
> 08.08.2016, 16:52, "Wei Yongjun" <weiyj.lk@gmail.com>:
>> Fix 'timeout_us' parameter description.
>>
>> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>> ---
>> drivers/w1/w1.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
>> index bb34362..e213c67 100644
>> --- a/drivers/w1/w1.c
>> +++ b/drivers/w1/w1.c
>> @@ -53,8 +53,8 @@ int w1_max_slave_ttl = 10;
>> module_param_named(timeout, w1_timeout, int, 0);
>> MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches");
>> module_param_named(timeout_us, w1_timeout_us, int, 0);
>> -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
>> - " searches");
>> +MODULE_PARM_DESC(timeout_us,
>> + "time in microseconds between automatic slave searches");
> I believe there will be no harm to put it to on one line, even if it crosses some obscure very-long-line rule
Maybe the bad patch description confused you, this patch the typo in the
first argument of MODULE_PARM_DESC(), use timeout_us instead of timeout.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] w1: fix timeout_us parameter description
2016-08-10 3:22 ` Wei Yongjun
@ 2016-08-10 20:00 ` Evgeniy Polyakov
0 siblings, 0 replies; 6+ messages in thread
From: Evgeniy Polyakov @ 2016-08-10 20:00 UTC (permalink / raw)
To: Wei Yongjun, Greg Kroah-Hartman; +Cc: linux-kernel@vger.kernel.org
Hi
10.08.2016, 06:22, "Wei Yongjun" <weiyj.lk@gmail.com>:
>> 08.08.2016, 16:52, "Wei Yongjun" <weiyj.lk@gmail.com>:
>>> Fix 'timeout_us' parameter description.
>>> MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches");
>>> module_param_named(timeout_us, w1_timeout_us, int, 0);
>>> -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
>>> - " searches");
>>> +MODULE_PARM_DESC(timeout_us,
>>> + "time in microseconds between automatic slave searches");
>> I believe there will be no harm to put it to on one line, even if it crosses some obscure very-long-line rule
>
> Maybe the bad patch description confused you, this patch the typo in the
> first argument of MODULE_PARM_DESC(), use timeout_us instead of timeout.
Yup, you are right, please make it as one line since you are at it
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] w1: fix typo in parameter description
2016-08-08 13:52 [PATCH] w1: fix timeout_us parameter description Wei Yongjun
2016-08-09 22:54 ` Evgeniy Polyakov
@ 2016-08-11 0:03 ` Wei Yongjun
2016-08-12 10:27 ` Evgeniy Polyakov
1 sibling, 1 reply; 6+ messages in thread
From: Wei Yongjun @ 2016-08-11 0:03 UTC (permalink / raw)
To: Evgeniy Polyakov; +Cc: Wei Yongjun, linux-kernel
Fix typo in parameter description.
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
v1 -> v2: make it as one line, comments from Evgeniy Polyakov
---
drivers/w1/w1.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index bb34362..4bd898b 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -53,8 +53,7 @@ int w1_max_slave_ttl = 10;
module_param_named(timeout, w1_timeout, int, 0);
MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches");
module_param_named(timeout_us, w1_timeout_us, int, 0);
-MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
- " searches");
+MODULE_PARM_DESC(timeout_us, "time in microseconds between automatic slave searches");
/* A search stops when w1_max_slave_count devices have been found in that
* search. The next search will start over and detect the same set of devices
* on a static 1-wire bus. Memory is not allocated based on this number, just
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] w1: fix typo in parameter description
2016-08-11 0:03 ` [PATCH v2] w1: fix typo in " Wei Yongjun
@ 2016-08-12 10:27 ` Evgeniy Polyakov
0 siblings, 0 replies; 6+ messages in thread
From: Evgeniy Polyakov @ 2016-08-12 10:27 UTC (permalink / raw)
To: Wei Yongjun, Greg KH; +Cc: linux-kernel@vger.kernel.org
Hi
11.08.2016, 03:03, "Wei Yongjun" <weiyj.lk@gmail.com>:
> Fix typo in parameter description.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Looks good to me, thank you
Greg, please pull it into your tree
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> ---
> v1 -> v2: make it as one line, comments from Evgeniy Polyakov
> ---
> drivers/w1/w1.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index bb34362..4bd898b 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -53,8 +53,7 @@ int w1_max_slave_ttl = 10;
> module_param_named(timeout, w1_timeout, int, 0);
> MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches");
> module_param_named(timeout_us, w1_timeout_us, int, 0);
> -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
> - " searches");
> +MODULE_PARM_DESC(timeout_us, "time in microseconds between automatic slave searches");
> /* A search stops when w1_max_slave_count devices have been found in that
> * search. The next search will start over and detect the same set of devices
> * on a static 1-wire bus. Memory is not allocated based on this number, just
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-12 10:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-08 13:52 [PATCH] w1: fix timeout_us parameter description Wei Yongjun
2016-08-09 22:54 ` Evgeniy Polyakov
2016-08-10 3:22 ` Wei Yongjun
2016-08-10 20:00 ` Evgeniy Polyakov
2016-08-11 0:03 ` [PATCH v2] w1: fix typo in " Wei Yongjun
2016-08-12 10:27 ` Evgeniy Polyakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox