From: Greg KH <greg@kroah.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: Patrick Mochel <mochel@osdl.org>,
Linus Torvalds <torvalds@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
andre@linux-ide.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] embedded struct device Re: [patch] IDE driver model update
Date: Tue, 8 Oct 2002 14:30:08 -0700 [thread overview]
Message-ID: <20021008213007.GA10193@kroah.com> (raw)
In-Reply-To: <Pine.GSO.4.21.0210081616120.5897-100000@weyl.math.psu.edu>
On Tue, Oct 08, 2002 at 04:47:49PM -0400, Alexander Viro wrote:
> >
> > The only timing issue is when the device structures are reused. And, it
> > seems that that is inherently racy anyway with hotpluggable devices.
>
> BS. Neither SCSI, nor USB nor PCI are reusing the structures in question.
> They are, however, freeing them.
>
> Again, USB disconnect when you are holding a reference to struct device
> will leave you with pointer to kfree'd area.
This is a USB (and PCI) bug. I'll fix them, they should be using the
release() callback that Pat has provided. With that callback, which
gets called when the device really wants to be cleaned up, I don't see
any races in the USB code (well theoretical races, there's still some
bugs in the current implementation that I'm trying to track down...)
thanks,
greg k-h
prev parent reply other threads:[~2002-10-08 21:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-07 19:30 [patch] IDE driver model update Patrick Mochel
2002-10-07 19:31 ` Patrick Mochel
2002-10-07 19:31 ` Patrick Mochel
2002-10-11 23:06 ` Pavel Machek
2002-10-07 19:31 ` Patrick Mochel
2002-10-07 22:42 ` Alexander Viro
2002-10-07 22:51 ` Patrick Mochel
2002-10-07 22:58 ` Alexander Viro
2002-10-07 23:06 ` Patrick Mochel
2002-10-08 2:17 ` Alexander Viro
2002-10-08 12:21 ` Alan Cox
2002-10-08 12:24 ` Alexander Viro
2002-10-08 13:05 ` Alan Cox
2002-10-08 19:18 ` Andries Brouwer
2002-10-08 13:25 ` jbradford
2002-10-08 14:31 ` Ketil Froyn
2002-10-08 21:34 ` Xavier Bestel
2002-10-08 21:57 ` Pavel Machek
2002-10-08 15:05 ` Benjamin Herrenschmidt
2002-10-08 18:43 ` Patrick Mochel
2002-10-08 20:47 ` [RFC] embedded struct device " Alexander Viro
2002-10-08 21:29 ` Linus Torvalds
2002-10-08 21:42 ` Alexander Viro
2002-10-08 21:53 ` Kai Germaschewski
2002-10-08 21:57 ` Patrick Mochel
2002-10-08 22:51 ` Alan Cox
2002-10-08 21:54 ` Patrick Mochel
2002-10-08 22:12 ` Linus Torvalds
2002-10-08 22:48 ` Kai Germaschewski
2002-10-08 23:28 ` Linus Torvalds
2002-10-08 22:29 ` Greg KH
2002-10-08 21:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021008213007.GA10193@kroah.com \
--to=greg@kroah.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andre@linux-ide.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox