Re: [patch] IDE driver model update

[Pavel Machek <pavel@ucw.cz>]

Hi!

> ChangeSet@1.696.19.2, 2002-10-07 10:27:16-07:00, mochel@osdl.org
>   IDE: register ide driver for all ide drives; not just for disk drives. 
>   
>   This adds
>   	struct device_driver	gen_driver;
>   
>   to ide_driver_t, which is filled in with necessary fields when an ide
>   driver calls ide_register_driver(). That then registers the driver with
>   the driver model core. 
>   
>   As a result, this gives us the following output in driverfs:
>   
>   # tree -d /sys/bus/ide/drivers/
>   /sys/bus/ide/drivers/
>   |-- ide-cdrom
>   `-- ide-disk
>   
>   The suspend/resume callbacks in ide-disk.c have been temporarily
>   disabled until the ide core implements generic methods which forward
>   the calls to the drive drivers. 
> 
> diff -Nru a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
> --- a/drivers/ide/ide-disk.c	Mon Oct  7 12:19:14 2002
> +++ b/drivers/ide/ide-disk.c	Mon Oct  7 12:19:14 2002
> @@ -1550,14 +1550,6 @@
>  /* This is just a hook for the overall driver tree.
>   */
>  
> -static struct device_driver idedisk_devdrv = {
> -	.bus = &ide_bus_type,
> -	.name = "IDE disk driver",
> -
> -	.suspend = idedisk_suspend,
> -	.resume = idedisk_resume,
> -};
> -

Here you killed the only reference to idedisk_suspend, yet
idedisk_suspend/idedisk_resume is needed if you don't want to eat
data.
							Pavel
-- 
When do you have heart between your knees?