public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Miles Bader <miles@gnu.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: !CONFIG_MMU stubs in 2.5.66
Date: Tue, 25 Mar 2003 07:47:39 +0100	[thread overview]
Message-ID: <20030325074739.A16342@lst.de> (raw)
In-Reply-To: <buod6kgaxhb.fsf@mcspd15.ucom.lsi.nec.co.jp>; from miles@lsi.nec.co.jp on Tue, Mar 25, 2003 at 01:20:16PM +0900

On Tue, Mar 25, 2003 at 01:20:16PM +0900, Miles Bader wrote:
> The following change in 2.5.66:
> 
>    [PATCH] a few missing stubs for !CONFIG_MMU
> 
>    Patch from Christoph Hellwig <hch@lst.de>
> 
>    This is from the uClinux patches - there are a few more stubs needed
>    in nommu.c to get the mmuless plattforms working.
> 
> Adds definitions for vmalloc_to_page, follow_page, and remap_page_range,
> to mm/mmnommu.c.  However, there are already inline definitions of those
> functions (predicated on !CONFIG_MMU) in linux/mm.h, so compilation
> fails.
> 
> Which is the correct location?

OOPS, it looks like Greg & me submitted paches in parallel.  Personally I
prefer the out of line ones over the inlines, especially as they handle
vmalloc_to_page properly.  I'll submit a patch to Linus to fix this
mess.


      reply	other threads:[~2003-03-25  6:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-25  4:20 !CONFIG_MMU stubs in 2.5.66 Miles Bader
2003-03-25  6:47 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030325074739.A16342@lst.de \
    --to=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox