public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* !CONFIG_MMU stubs in 2.5.66
@ 2003-03-25  4:20 Miles Bader
  2003-03-25  6:47 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Miles Bader @ 2003-03-25  4:20 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: linux-kernel

The following change in 2.5.66:

   [PATCH] a few missing stubs for !CONFIG_MMU

   Patch from Christoph Hellwig <hch@lst.de>

   This is from the uClinux patches - there are a few more stubs needed
   in nommu.c to get the mmuless plattforms working.

Adds definitions for vmalloc_to_page, follow_page, and remap_page_range,
to mm/mmnommu.c.  However, there are already inline definitions of those
functions (predicated on !CONFIG_MMU) in linux/mm.h, so compilation
fails.

Which is the correct location?

[I locally removed the defs in linux/mm.h to get things to compile]

Thanks,

-Miles
-- 
[|nurgle|]  ddt- demonic? so quake will have an evil kinda setting? one that 
            will  make every christian in the world foamm at the mouth? 
[iddt]      nurg, that's the goal 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: !CONFIG_MMU stubs in 2.5.66
  2003-03-25  4:20 !CONFIG_MMU stubs in 2.5.66 Miles Bader
@ 2003-03-25  6:47 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2003-03-25  6:47 UTC (permalink / raw)
  To: Miles Bader; +Cc: linux-kernel

On Tue, Mar 25, 2003 at 01:20:16PM +0900, Miles Bader wrote:
> The following change in 2.5.66:
> 
>    [PATCH] a few missing stubs for !CONFIG_MMU
> 
>    Patch from Christoph Hellwig <hch@lst.de>
> 
>    This is from the uClinux patches - there are a few more stubs needed
>    in nommu.c to get the mmuless plattforms working.
> 
> Adds definitions for vmalloc_to_page, follow_page, and remap_page_range,
> to mm/mmnommu.c.  However, there are already inline definitions of those
> functions (predicated on !CONFIG_MMU) in linux/mm.h, so compilation
> fails.
> 
> Which is the correct location?

OOPS, it looks like Greg & me submitted paches in parallel.  Personally I
prefer the out of line ones over the inlines, especially as they handle
vmalloc_to_page properly.  I'll submit a patch to Linus to fix this
mess.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-03-25  6:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-03-25  4:20 !CONFIG_MMU stubs in 2.5.66 Miles Bader
2003-03-25  6:47 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox