* [patch] fix .text.exit error in drivers/net/r8169.c
@ 2003-03-27 22:13 Adrian Bunk
2003-03-27 22:19 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2003-03-27 22:13 UTC (permalink / raw)
To: Jeff Garzik, Marcelo Tosatti, Linus Torvalds; +Cc: linux-kernel
In drivers/net/r8169.c the function rtl8169_remove_one is __devexit but
the pointer to it didn't use __devexit_p resulting in a.text.exit
compile error when !CONFIG_HOTPLUG.
The fix is simple:
--- linux-2.4.21-pre6-full-nohotplug/drivers/net/r8169.c.old 2003-03-27 22:17:09.000000000 +0100
+++ linux-2.4.21-pre6-full-nohotplug/drivers/net/r8169.c 2003-03-27 22:19:18.000000000 +0100
@@ -1110,7 +1110,7 @@
.name = MODULENAME,
.id_table = rtl8169_pci_tbl,
.probe = rtl8169_init_one,
- .remove = rtl8169_remove_one,
+ .remove = __devexit_p(rtl8169_remove_one),
.suspend = NULL,
.resume = NULL,
};
The patch applies against 2.4.21-pre6 and 2.5.66. I've tested the
compilation with 2.4.21-pre6.
Please apply
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-03-27 22:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-03-27 22:13 [patch] fix .text.exit error in drivers/net/r8169.c Adrian Bunk
2003-03-27 22:19 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox