* 2.5.70: CODA breaks boot @ 2003-05-28 11:24 Pavel Machek 2003-05-28 11:36 ` Andrew Morton 0 siblings, 1 reply; 5+ messages in thread From: Pavel Machek @ 2003-05-28 11:24 UTC (permalink / raw) To: kernel list Hi! ...it oopses in kmem_cache_create, called from release_console_sem and coda_init_inodecache. Pavel -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.5.70: CODA breaks boot 2003-05-28 11:24 2.5.70: CODA breaks boot Pavel Machek @ 2003-05-28 11:36 ` Andrew Morton 2003-05-28 21:00 ` Riley Williams 0 siblings, 1 reply; 5+ messages in thread From: Andrew Morton @ 2003-05-28 11:36 UTC (permalink / raw) To: Pavel Machek; +Cc: linux-kernel Pavel Machek <pavel@ucw.cz> wrote: > > ...it oopses in kmem_cache_create, called from release_console_sem and > coda_init_inodecache. You'll be needing this one. fs/coda/inode.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff -puN fs/coda/inode.c~coda-typo-fix fs/coda/inode.c --- 25/fs/coda/inode.c~coda-typo-fix 2003-05-27 22:27:11.000000000 -0700 +++ 25-akpm/fs/coda/inode.c 2003-05-27 22:27:27.000000000 -0700 @@ -69,9 +69,9 @@ static void init_once(void * foo, kmem_c int coda_init_inodecache(void) { coda_inode_cachep = kmem_cache_create("coda_inode_cache", - sizeof(struct coda_inode_info), - 0, SLAB_HWCACHE_ALIGN||SLAB_RECLAIM_ACCOUNT, - init_once, NULL); + sizeof(struct coda_inode_info), + 0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT, + init_once, NULL); if (coda_inode_cachep == NULL) return -ENOMEM; return 0; _ ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: 2.5.70: CODA breaks boot 2003-05-28 11:36 ` Andrew Morton @ 2003-05-28 21:00 ` Riley Williams 2003-05-28 21:05 ` Randy.Dunlap 2003-05-28 21:08 ` Arnaldo Carvalho de Melo 0 siblings, 2 replies; 5+ messages in thread From: Riley Williams @ 2003-05-28 21:00 UTC (permalink / raw) To: Andrew Morton, Pavel Machek; +Cc: linux-kernel Hi Andrew. >> ...it oopses in kmem_cache_create, called from release_console_sem and >> coda_init_inodecache. > You'll be needing this one. > > fs/coda/inode.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff -puN fs/coda/inode.c~coda-typo-fix fs/coda/inode.c > --- 25/fs/coda/inode.c~coda-typo-fix 2003-05-27 22:27:11.000000000 -0700 > +++ 25-akpm/fs/coda/inode.c 2003-05-27 22:27:27.000000000 -0700 > @@ -69,9 +69,9 @@ static void init_once(void * foo, kmem_c > int coda_init_inodecache(void) > { > coda_inode_cachep = kmem_cache_create("coda_inode_cache", > - sizeof(struct coda_inode_info), > + sizeof(struct coda_inode_info), > - 0, SLAB_HWCACHE_ALIGN||SLAB_RECLAIM_ACCOUNT, > + 0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT, > - init_once, NULL); > + init_once, NULL); > if (coda_inode_cachep == NULL) > return -ENOMEM; > return 0; That patch has me puzzled. Other than changing the white space, what actual change to the code does it make? I can't see any. Best wishes from Riley. --- * Nothing as pretty as a smile, nothing as ugly as a frown. --- Outgoing mail is certified Virus Free. Checked by AVG anti-virus system (http://www.grisoft.com). Version: 6.0.484 / Virus Database: 282 - Release Date: 27-May-2003 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.5.70: CODA breaks boot 2003-05-28 21:00 ` Riley Williams @ 2003-05-28 21:05 ` Randy.Dunlap 2003-05-28 21:08 ` Arnaldo Carvalho de Melo 1 sibling, 0 replies; 5+ messages in thread From: Randy.Dunlap @ 2003-05-28 21:05 UTC (permalink / raw) To: Riley Williams; +Cc: akpm, pavel, linux-kernel | > fs/coda/inode.c | 6 +++--- | > 1 files changed, 3 insertions(+), 3 deletions(-) | > | > diff -puN fs/coda/inode.c~coda-typo-fix fs/coda/inode.c | > --- 25/fs/coda/inode.c~coda-typo-fix 2003-05-27 22:27:11.000000000 -0700 | > +++ 25-akpm/fs/coda/inode.c 2003-05-27 22:27:27.000000000 -0700 | > @@ -69,9 +69,9 @@ static void init_once(void * foo, kmem_c | > int coda_init_inodecache(void) | > { | > coda_inode_cachep = kmem_cache_create("coda_inode_cache", | > - sizeof(struct coda_inode_info), | > + sizeof(struct coda_inode_info), | > - 0, SLAB_HWCACHE_ALIGN||SLAB_RECLAIM_ACCOUNT, ^^ change to | | > + 0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT, | > - init_once, NULL); | > + init_once, NULL); | > if (coda_inode_cachep == NULL) | > return -ENOMEM; | > return 0; | | That patch has me puzzled. Other than changing the white space, what actual | change to the code does it make? I can't see any. See above. Yes, I understand. :) -- ~Randy ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.5.70: CODA breaks boot 2003-05-28 21:00 ` Riley Williams 2003-05-28 21:05 ` Randy.Dunlap @ 2003-05-28 21:08 ` Arnaldo Carvalho de Melo 1 sibling, 0 replies; 5+ messages in thread From: Arnaldo Carvalho de Melo @ 2003-05-28 21:08 UTC (permalink / raw) To: Riley Williams; +Cc: Andrew Morton, Pavel Machek, linux-kernel Em Wed, May 28, 2003 at 10:00:06PM +0100, Riley Williams escreveu: > Hi Andrew. > > >> ...it oopses in kmem_cache_create, called from release_console_sem and > >> coda_init_inodecache. > > > You'll be needing this one. > > > > fs/coda/inode.c | 6 +++--- > > 1 files changed, 3 insertions(+), 3 deletions(-) > > > > diff -puN fs/coda/inode.c~coda-typo-fix fs/coda/inode.c > > --- 25/fs/coda/inode.c~coda-typo-fix 2003-05-27 22:27:11.000000000 -0700 > > +++ 25-akpm/fs/coda/inode.c 2003-05-27 22:27:27.000000000 -0700 > > @@ -69,9 +69,9 @@ static void init_once(void * foo, kmem_c > > int coda_init_inodecache(void) > > { > > coda_inode_cachep = kmem_cache_create("coda_inode_cache", > > - sizeof(struct coda_inode_info), > > + sizeof(struct coda_inode_info), > > - 0, SLAB_HWCACHE_ALIGN||SLAB_RECLAIM_ACCOUNT, ^^ logical OR > > + 0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT, ^ bit or > > - init_once, NULL); > > + init_once, NULL); > > if (coda_inode_cachep == NULL) > > return -ENOMEM; > > return 0; > > That patch has me puzzled. Other than changing the white space, what actual > change to the code does it make? I can't see any. gotcha? 8) - Arnaldo ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-05-28 20:55 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2003-05-28 11:24 2.5.70: CODA breaks boot Pavel Machek 2003-05-28 11:36 ` Andrew Morton 2003-05-28 21:00 ` Riley Williams 2003-05-28 21:05 ` Randy.Dunlap 2003-05-28 21:08 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox