* [patch] qlogic_cs: init legacy_hosts
@ 2003-10-20 23:25 Aristeu Sergio Rozanski Filho
2003-10-21 8:11 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Aristeu Sergio Rozanski Filho @ 2003-10-20 23:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Jeff Garzik, Christoph Hellwig, Mike Christie
[-- Attachment #1: Type: text/plain, Size: 10 bytes --]
--
aris
[-- Attachment #2: qlogic-init_legacy_hosts.patch --]
[-- Type: text/plain, Size: 450 bytes --]
--- linux/drivers/scsi/pcmcia/qlogic_stub.c.orig 2003-10-20 21:04:02.000000000 -0200
+++ linux/drivers/scsi/pcmcia/qlogic_stub.c 2003-10-20 21:05:02.000000000 -0200
@@ -249,6 +249,8 @@
else
qlogicfas_preset(link->io.BasePort1, link->irq.AssignedIRQ);
+ INIT_LIST_HEAD(&qlogicfas_driver_template.legacy_hosts);
+
host = __qlogicfas_detect(&qlogicfas_driver_template);
if (!host) {
printk(KERN_INFO "qlogic_cs: no SCSI devices found\n");
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch] qlogic_cs: init legacy_hosts
2003-10-20 23:25 [patch] qlogic_cs: init legacy_hosts Aristeu Sergio Rozanski Filho
@ 2003-10-21 8:11 ` Christoph Hellwig
2003-10-21 9:28 ` Aristeu Sergio Rozanski Filho
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2003-10-21 8:11 UTC (permalink / raw)
To: Aristeu Sergio Rozanski Filho; +Cc: linux-kernel, Jeff Garzik, Mike Christie
On Mon, Oct 20, 2003 at 09:25:23PM -0200, Aristeu Sergio Rozanski Filho wrote:
> --
> aris
>
> --- linux/drivers/scsi/pcmcia/qlogic_stub.c.orig 2003-10-20 21:04:02.000000000 -0200
> +++ linux/drivers/scsi/pcmcia/qlogic_stub.c 2003-10-20 21:05:02.000000000 -0200
> @@ -249,6 +249,8 @@
> else
> qlogicfas_preset(link->io.BasePort1, link->irq.AssignedIRQ);
>
> + INIT_LIST_HEAD(&qlogicfas_driver_template.legacy_hosts);
> +
qlogic_cs is a newstyle driver, no need to initialize it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] qlogic_cs: init legacy_hosts
2003-10-21 8:11 ` Christoph Hellwig
@ 2003-10-21 9:28 ` Aristeu Sergio Rozanski Filho
2003-10-21 9:57 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Aristeu Sergio Rozanski Filho @ 2003-10-21 9:28 UTC (permalink / raw)
To: Christoph Hellwig, linux-kernel, Jeff Garzik, Mike Christie
hi Christoph,
> > @@ -249,6 +249,8 @@
> > else
> > qlogicfas_preset(link->io.BasePort1, link->irq.AssignedIRQ);
> >
> > + INIT_LIST_HEAD(&qlogicfas_driver_template.legacy_hosts);
> > +
>
> qlogic_cs is a newstyle driver, no need to initialize it.
then it needs more work. without initializing it i get an oops in
scsi_register(). i guess the qlogic_cs is an oldstyle driver by now
because it uses qlogicfas template and functions.
--
aris
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] qlogic_cs: init legacy_hosts
2003-10-21 9:28 ` Aristeu Sergio Rozanski Filho
@ 2003-10-21 9:57 ` Christoph Hellwig
2003-10-21 10:06 ` Aristeu Sergio Rozanski Filho
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2003-10-21 9:57 UTC (permalink / raw)
To: Aristeu Sergio Rozanski Filho; +Cc: linux-kernel, Jeff Garzik, Mike Christie
On Tue, Oct 21, 2003 at 07:28:58AM -0200, Aristeu Sergio Rozanski Filho wrote:
> hi Christoph,
> > > @@ -249,6 +249,8 @@
> > > else
> > > qlogicfas_preset(link->io.BasePort1, link->irq.AssignedIRQ);
> > >
> > > + INIT_LIST_HEAD(&qlogicfas_driver_template.legacy_hosts);
> > > +
> >
> > qlogic_cs is a newstyle driver, no need to initialize it.
> then it needs more work. without initializing it i get an oops in
> scsi_register(). i guess the qlogic_cs is an oldstyle driver by now
> because it uses qlogicfas template and functions.
why do you call scsi_register at all? You need to uses scsi_host_alloc in
the pcmcia case.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] qlogic_cs: init legacy_hosts
2003-10-21 9:57 ` Christoph Hellwig
@ 2003-10-21 10:06 ` Aristeu Sergio Rozanski Filho
0 siblings, 0 replies; 5+ messages in thread
From: Aristeu Sergio Rozanski Filho @ 2003-10-21 10:06 UTC (permalink / raw)
To: Christoph Hellwig, linux-kernel, Jeff Garzik, Mike Christie
> > > qlogic_cs is a newstyle driver, no need to initialize it.
> > then it needs more work. without initializing it i get an oops in
> > scsi_register(). i guess the qlogic_cs is an oldstyle driver by now
> > because it uses qlogicfas template and functions.
>
> why do you call scsi_register at all? You need to uses scsi_host_alloc in
> the pcmcia case.
actually qlogic_cs calls __qlogicfas_detect() that calls
scsi_register(). i'll work on this.
--
aris
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-10-21 10:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-20 23:25 [patch] qlogic_cs: init legacy_hosts Aristeu Sergio Rozanski Filho
2003-10-21 8:11 ` Christoph Hellwig
2003-10-21 9:28 ` Aristeu Sergio Rozanski Filho
2003-10-21 9:57 ` Christoph Hellwig
2003-10-21 10:06 ` Aristeu Sergio Rozanski Filho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox