* [PATCH] OProfile driver in 2.6
@ 2004-06-02 9:19 Jens Schmalzing
2004-06-02 15:50 ` Tom Rini
2004-06-02 17:03 ` Philippe Elie
0 siblings, 2 replies; 6+ messages in thread
From: Jens Schmalzing @ 2004-06-02 9:19 UTC (permalink / raw)
To: linux-kernel; +Cc: benh
[-- Attachment #1: Type: text/plain, Size: 266 bytes --]
Hi,
I noticed that the driver for the OProfile profiling system, which
existed in the linuxppc-2.5-benh tree, is disabled in the mainline,
even though the driver still exists. Is there a reason for this? The
attached patch re-enables the driver.
Regards, Jens.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: OProfile profiling system --]
[-- Type: text/x-patch, Size: 2464 bytes --]
diff -Nur kernel-source-2.6.6/arch/ppc/Kconfig linuxppc-2.5-benh/arch/ppc/Kconfig
--- kernel-source-2.6.6/arch/ppc/Kconfig 2004-04-05 11:49:23.000000000 +0200
+++ linuxppc-2.5-benh/arch/ppc/Kconfig 2004-03-29 08:34:26.000000000 +0200
@@ -1121,6 +1121,7 @@
source "lib/Kconfig"
+source "arch/ppc/oprofile/Kconfig"
menu "Kernel hacking"
diff -Nur kernel-source-2.6.6/arch/ppc/oprofile/Kconfig linuxppc-2.5-benh/arch/ppc/oprofile/Kconfig
--- kernel-source-2.6.6/arch/ppc/oprofile/Kconfig 1970-01-01 01:00:00.000000000 +0100
+++ linuxppc-2.5-benh/arch/ppc/oprofile/Kconfig 2003-12-31 03:50:43.000000000 +0100
@@ -0,0 +1,23 @@
+
+menu "Profiling support"
+ depends on EXPERIMENTAL
+
+config PROFILING
+ bool "Profiling support (EXPERIMENTAL)"
+ help
+ Say Y here to enable the extended profiling support mechanisms used
+ by profilers such as OProfile.
+
+
+config OPROFILE
+ tristate "OProfile system profiling (EXPERIMENTAL)"
+ depends on PROFILING
+ help
+ OProfile is a profiling system capable of profiling the
+ whole system, include the kernel, kernel modules, libraries,
+ and applications.
+
+ If unsure, say N.
+
+endmenu
+
diff -Nur kernel-source-2.6.6/arch/ppc/oprofile/Makefile linuxppc-2.5-benh/arch/ppc/oprofile/Makefile
--- kernel-source-2.6.6/arch/ppc/oprofile/Makefile 1970-01-01 01:00:00.000000000 +0100
+++ linuxppc-2.5-benh/arch/ppc/oprofile/Makefile 2003-12-31 03:50:44.000000000 +0100
@@ -0,0 +1,9 @@
+obj-$(CONFIG_OPROFILE) += oprofile.o
+
+DRIVER_OBJS := $(addprefix ../../../drivers/oprofile/, \
+ oprof.o cpu_buffer.o buffer_sync.o \
+ event_buffer.o oprofile_files.o \
+ oprofilefs.o oprofile_stats.o \
+ timer_int.o )
+
+oprofile-y := $(DRIVER_OBJS) init.o
diff -Nur kernel-source-2.6.6/arch/ppc/oprofile/init.c linuxppc-2.5-benh/arch/ppc/oprofile/init.c
--- kernel-source-2.6.6/arch/ppc/oprofile/init.c 1970-01-01 01:00:00.000000000 +0100
+++ linuxppc-2.5-benh/arch/ppc/oprofile/init.c 2003-12-31 03:50:45.000000000 +0100
@@ -0,0 +1,25 @@
+/**
+ * @file init.c
+ *
+ * @remark Copyright 2002 OProfile authors
+ * @remark Read the file COPYING
+ *
+ * @author John Levon <levon@movementarian.org>
+ */
+
+#include <linux/kernel.h>
+#include <linux/oprofile.h>
+#include <linux/init.h>
+#include <linux/errno.h>
+
+extern void timer_init(struct oprofile_operations ** ops);
+
+int __init oprofile_arch_init(struct oprofile_operations ** ops)
+{
+ return -ENODEV;
+}
+
+
+void oprofile_arch_exit(void)
+{
+}
[-- Attachment #3: Type: text/plain, Size: 99 bytes --]
--
J'qbpbe, le m'en fquz pe j'qbpbe!
Le veux aimeb et mqubib panz je pézqbpbe je djuz tqtaj!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] OProfile driver in 2.6
2004-06-02 9:19 [PATCH] OProfile driver in 2.6 Jens Schmalzing
@ 2004-06-02 15:50 ` Tom Rini
2004-06-02 18:37 ` Philippe Elie
2004-06-02 20:12 ` Jens Schmalzing
2004-06-02 17:03 ` Philippe Elie
1 sibling, 2 replies; 6+ messages in thread
From: Tom Rini @ 2004-06-02 15:50 UTC (permalink / raw)
To: Jens Schmalzing; +Cc: linux-kernel, benh
On Wed, Jun 02, 2004 at 11:19:41AM +0200, Jens Schmalzing wrote:
> Hi,
>
> I noticed that the driver for the OProfile profiling system, which
> existed in the linuxppc-2.5-benh tree, is disabled in the mainline,
> even though the driver still exists. Is there a reason for this? The
> attached patch re-enables the driver.
Because it has never been picked up, aside from when Ben took it into
his tree (assuming this is the patch Anton wrote a while back, and not
a re-write Ben did). BTW, this is missing a hunk I think, unless the
arch/ppc/kernel/time.c changes have already made it in.
--
Tom Rini
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] OProfile driver in 2.6
2004-06-02 9:19 [PATCH] OProfile driver in 2.6 Jens Schmalzing
2004-06-02 15:50 ` Tom Rini
@ 2004-06-02 17:03 ` Philippe Elie
1 sibling, 0 replies; 6+ messages in thread
From: Philippe Elie @ 2004-06-02 17:03 UTC (permalink / raw)
To: Jens Schmalzing; +Cc: linux-kernel, benh
On Wed, 02 Jun 2004 at 11:19 +0000, Jens Schmalzing wrote:
> Hi,
>
> I noticed that the driver for the OProfile profiling system, which
> existed in the linuxppc-2.5-benh tree, is disabled in the mainline,
> even though the driver still exists. Is there a reason for this? The
> attached patch re-enables the driver.
I don't remember any reason, no test box perhaps ?
The patch looks fine
regards,
Phil
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] OProfile driver in 2.6
2004-06-02 18:37 ` Philippe Elie
@ 2004-06-02 17:51 ` Greg Weeks
0 siblings, 0 replies; 6+ messages in thread
From: Greg Weeks @ 2004-06-02 17:51 UTC (permalink / raw)
To: linux-kernel; +Cc: benh
Philippe Elie wrote:
>On Wed, 02 Jun 2004 at 08:50 +0000, Tom Rini wrote:
>
>
>
>>On Wed, Jun 02, 2004 at 11:19:41AM +0200, Jens Schmalzing wrote:
>>
>>
>>
>>>Hi,
>>>
>>>I noticed that the driver for the OProfile profiling system, which
>>>existed in the linuxppc-2.5-benh tree, is disabled in the mainline,
>>>even though the driver still exists. Is there a reason for this? The
>>>attached patch re-enables the driver.
>>>
>>>
>>Because it has never been picked up, aside from when Ben took it into
>>his tree (assuming this is the patch Anton wrote a while back, and not
>>a re-write Ben did). BTW, this is missing a hunk I think, unless the
>>arch/ppc/kernel/time.c changes have already made it in.
>>
>>
>
>Right there is a missing call to profile_hook(regs); in ppc_do_profile()
>
>
The patch I've been using for ppc oprofile is archived here.
http://www.cs.helsinki.fi/linux/linux-kernel/2003-09/1228.html
I've always wondered why it never got picked up.
Greg Weeks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] OProfile driver in 2.6
2004-06-02 15:50 ` Tom Rini
@ 2004-06-02 18:37 ` Philippe Elie
2004-06-02 17:51 ` Greg Weeks
2004-06-02 20:12 ` Jens Schmalzing
1 sibling, 1 reply; 6+ messages in thread
From: Philippe Elie @ 2004-06-02 18:37 UTC (permalink / raw)
To: Tom Rini; +Cc: Jens Schmalzing, linux-kernel, benh
On Wed, 02 Jun 2004 at 08:50 +0000, Tom Rini wrote:
> On Wed, Jun 02, 2004 at 11:19:41AM +0200, Jens Schmalzing wrote:
>
> > Hi,
> >
> > I noticed that the driver for the OProfile profiling system, which
> > existed in the linuxppc-2.5-benh tree, is disabled in the mainline,
> > even though the driver still exists. Is there a reason for this? The
> > attached patch re-enables the driver.
>
> Because it has never been picked up, aside from when Ben took it into
> his tree (assuming this is the patch Anton wrote a while back, and not
> a re-write Ben did). BTW, this is missing a hunk I think, unless the
> arch/ppc/kernel/time.c changes have already made it in.
Right there is a missing call to profile_hook(regs); in ppc_do_profile()
regards,
Phil
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] OProfile driver in 2.6
2004-06-02 15:50 ` Tom Rini
2004-06-02 18:37 ` Philippe Elie
@ 2004-06-02 20:12 ` Jens Schmalzing
1 sibling, 0 replies; 6+ messages in thread
From: Jens Schmalzing @ 2004-06-02 20:12 UTC (permalink / raw)
To: Tom Rini; +Cc: linux-kernel, benh
Hi,
Tom Rini writes:
> BTW, this is missing a hunk I think, unless the
> arch/ppc/kernel/time.c changes have already made it in.
Of course you are correct. Greg Weeks already posted a link to the
complete patch.
Regards, Jens.
--
J'qbpbe, le m'en fquz pe j'qbpbe!
Le veux aimeb et mqubib panz je pézqbpbe je djuz tqtaj!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-06-02 20:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-02 9:19 [PATCH] OProfile driver in 2.6 Jens Schmalzing
2004-06-02 15:50 ` Tom Rini
2004-06-02 18:37 ` Philippe Elie
2004-06-02 17:51 ` Greg Weeks
2004-06-02 20:12 ` Jens Schmalzing
2004-06-02 17:03 ` Philippe Elie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox