[patch] make netpoll_set_trap EXPORT_SYMBOL_GPL

[patch] make netpoll_set_trap EXPORT_SYMBOL_GPL

[Jeff Moyer]

Hi, Matt,

I believe that we should export the netpoll_set_trap routine as GPL only,
since vendors could conceivably use it to by-pass the networking stack
completely.  Jeff, correct me if I'm wrong, but I think this is what you
intended when you commented on it many months ago (sorry, can't find the
thread).

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>

--- linux-2.6.7/net/core/netpoll.c.gpl	2004-08-16 17:11:52.773312560 -0400
+++ linux-2.6.7/net/core/netpoll.c	2004-08-16 17:12:42.146806648 -0400
@@ -678,8 +678,8 @@ void netpoll_set_trap(int trap)
 		atomic_dec(&trapped);
 }
 
-EXPORT_SYMBOL(netpoll_set_trap);
-EXPORT_SYMBOL(netpoll_trap);
+EXPORT_SYMBOL_GPL(netpoll_set_trap);
+EXPORT_SYMBOL_GPL(netpoll_trap);
 EXPORT_SYMBOL(netpoll_parse_options);
 EXPORT_SYMBOL(netpoll_setup);
 EXPORT_SYMBOL(netpoll_cleanup);

Re: [patch] make netpoll_set_trap EXPORT_SYMBOL_GPL

[Matt Mackall]

On Mon, Aug 16, 2004 at 06:38:08PM -0400, Jeff Moyer wrote:
> Hi, Matt,
> 
> I believe that we should export the netpoll_set_trap routine as GPL only,
> since vendors could conceivably use it to by-pass the networking stack
> completely.  Jeff, correct me if I'm wrong, but I think this is what you
> intended when you commented on it many months ago (sorry, can't find the
> thread).

Hmmm, thought I closed that hole the first time around. How do you
envision bypassing the stack in the current approach?

-- 
Mathematics is the supreme nostalgia of our time.