* [patch] make netpoll_set_trap EXPORT_SYMBOL_GPL
@ 2004-08-16 22:38 Jeff Moyer
2004-08-16 23:12 ` Matt Mackall
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Moyer @ 2004-08-16 22:38 UTC (permalink / raw)
To: mpm; +Cc: jgarzik, linux-kernel
Hi, Matt,
I believe that we should export the netpoll_set_trap routine as GPL only,
since vendors could conceivably use it to by-pass the networking stack
completely. Jeff, correct me if I'm wrong, but I think this is what you
intended when you commented on it many months ago (sorry, can't find the
thread).
Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
--- linux-2.6.7/net/core/netpoll.c.gpl 2004-08-16 17:11:52.773312560 -0400
+++ linux-2.6.7/net/core/netpoll.c 2004-08-16 17:12:42.146806648 -0400
@@ -678,8 +678,8 @@ void netpoll_set_trap(int trap)
atomic_dec(&trapped);
}
-EXPORT_SYMBOL(netpoll_set_trap);
-EXPORT_SYMBOL(netpoll_trap);
+EXPORT_SYMBOL_GPL(netpoll_set_trap);
+EXPORT_SYMBOL_GPL(netpoll_trap);
EXPORT_SYMBOL(netpoll_parse_options);
EXPORT_SYMBOL(netpoll_setup);
EXPORT_SYMBOL(netpoll_cleanup);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] make netpoll_set_trap EXPORT_SYMBOL_GPL
2004-08-16 22:38 [patch] make netpoll_set_trap EXPORT_SYMBOL_GPL Jeff Moyer
@ 2004-08-16 23:12 ` Matt Mackall
0 siblings, 0 replies; 2+ messages in thread
From: Matt Mackall @ 2004-08-16 23:12 UTC (permalink / raw)
To: Jeff Moyer; +Cc: jgarzik, linux-kernel
On Mon, Aug 16, 2004 at 06:38:08PM -0400, Jeff Moyer wrote:
> Hi, Matt,
>
> I believe that we should export the netpoll_set_trap routine as GPL only,
> since vendors could conceivably use it to by-pass the networking stack
> completely. Jeff, correct me if I'm wrong, but I think this is what you
> intended when you commented on it many months ago (sorry, can't find the
> thread).
Hmmm, thought I closed that hole the first time around. How do you
envision bypassing the stack in the current approach?
--
Mathematics is the supreme nostalgia of our time.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-08-16 23:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-16 22:38 [patch] make netpoll_set_trap EXPORT_SYMBOL_GPL Jeff Moyer
2004-08-16 23:12 ` Matt Mackall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox