[2.6.11.3] gcc4 / psmouse.h - compilation fix.

[2.6.11.3] gcc4 / psmouse.h - compilation fix.

[Paweł Sikora]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

Hi,

Attched patch fixes gcc error:
`drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete type`

Please apply.

-- 
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */

                           #define say(x) lie(x)

[-- Attachment #2: 2.6.11.3-gcc4-psmouse.patch --]
[-- Type: text/x-diff, Size: 452 bytes --]

drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete type

--- linux-2.6.11.3/drivers/input/mouse/psmouse.h.orig	2005-03-13 07:44:40.000000000 +0100
+++ linux-2.6.11.3/drivers/input/mouse/psmouse.h	2005-03-13 14:08:06.000000000 +0100
@@ -1,6 +1,8 @@
 #ifndef _PSMOUSE_H
 #define _PSMOUSE_H
 
+#include <linux/libps2.h>
+
 #define PSMOUSE_CMD_SETSCALE11	0x00e6
 #define PSMOUSE_CMD_SETSCALE21	0x00e7
 #define PSMOUSE_CMD_SETRES	0x10e8

Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix.

[Dmitry Torokhov]

On Sunday 13 March 2005 08:20, Paweł Sikora wrote:
> Hi,
> 
> Attched patch fixes gcc error:
> `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete type`
> 

What file fails compilation? As far as I can see all users of psmouse.h do
#include <linux/libps2.h> first.

-- 
Dmitry

Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix.

[Paweł Sikora]

On Sunday 13 of March 2005 17:48, Dmitry Torokhov wrote:
> On Sunday 13 March 2005 08:20, Paweł Sikora wrote:
> > Hi,
> >
> > Attched patch fixes gcc error:
> > `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete
> > type`
>
> What file fails compilation?

custom patch for trackpoint device.

> As far as I can see all users of psmouse.h do 
> #include <linux/libps2.h> first.

IMHO each header (e.g. psmouse.h) should include headers for types it uses.

-- 
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */

                           #define say(x) lie(x)

Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix.

[Dmitry Torokhov]

On Sunday 13 March 2005 11:54, Paweł Sikora wrote:
> On Sunday 13 of March 2005 17:48, Dmitry Torokhov wrote:
> > On Sunday 13 March 2005 08:20, Paweł Sikora wrote:
> > > Hi,
> > >
> > > Attched patch fixes gcc error:
> > > `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete
> > > type`
> >
> > What file fails compilation?
> 
> custom patch for trackpoint device.
> 
> > As far as I can see all users of psmouse.h do 
> > #include <linux/libps2.h> first.
> 
> IMHO each header (e.g. psmouse.h) should include headers for types it uses.
> 

Hmm, I thought it was other way around to make it easier to track all users
of a particular header file.

-- 
Dmitry

Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix.

[Paul Jackson]

Dmitry, responding to Pawe__:
> > IMHO each header (e.g. psmouse.h) should include headers for types it uses.
> > 
> 
> Hmm, I thought it was other way around 

I tend to agree with Pawe__ here.

There are two extremes here that I would avoid.  Do not try to include
in source files every header that is directly or indirectly needed, nor
try to minimize inclusions in header files by relying on every possible
prerequisite inclusion by the includers of that header.

Rather - think about the interface presented and used.

A source file should include headers for everything that it manifestly
makes use of (even if that means it happened to include something that
was also indirectly included elsewhere).  And no more.

A header file should provide all the inclusions that its users
(includers) will need to make use of what is in that header file,
without presuming that any user will already have included something
else.  And no less.

In this case, it seems that the header drivers/input/mouse/psmouse.h
requires the size of a struct ps2dev.  So I would think that psmouse.h
should include linux/libps2.h, as this patch provides for.  The users
of psmouse.h should not have to know of this dependency.

Respect the interfaces.  They are one of the means whereby we partial
out responsibility for keeping code sane, in the face of rapid,
conflicting changes from many developers across many architectures and
drivers, where no one individual can test all possible configurations.

A user of psmouse.h should not be required to include the libps2.h
header, because someday a user of psmouse.h that didn't do this, but was
working anyway because it happened to get libps2.h from some other
indirect inclusion, will get broken when someone working in a quite
different area happens to deprive our hapless psmouse.h user of its
libps2.h.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@engr.sgi.com> 1.650.933.1373, 1.925.600.0401