* [PATCH] fix boot hang on some architectures
@ 2005-04-02 19:46 James Bottomley
2005-04-03 15:21 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2005-04-02 19:46 UTC (permalink / raw)
To: Andrew Morton, Linus Torvalds; +Cc: acme, Linux Kernel
Well, this is a brown paper bag for someone. The new protocol
registration locking uses a rwlock to limit access to the protocol list.
Unfortunately, the initialisation:
static rwlock_t proto_list_lock;
Only works to initialise the lock as unlocked on platforms whose unlock
signal is all zeros. On other platforms, they think it's already locked
and hang forever.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
===== net/core/sock.c 1.67 vs edited =====
--- 1.67/net/core/sock.c 2005-03-26 17:04:35 -06:00
+++ edited/net/core/sock.c 2005-04-02 13:37:20 -06:00
@@ -1352,7 +1352,7 @@
EXPORT_SYMBOL(sk_common_release);
-static rwlock_t proto_list_lock;
+static DEFINE_RWLOCK(proto_list_lock);
static LIST_HEAD(proto_list);
int proto_register(struct proto *prot, int alloc_slab)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix boot hang on some architectures
2005-04-02 19:46 [PATCH] fix boot hang on some architectures James Bottomley
@ 2005-04-03 15:21 ` Arnaldo Carvalho de Melo
2005-04-03 21:22 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2005-04-03 15:21 UTC (permalink / raw)
To: David S. Miller, James Bottomley
Cc: Andrew Morton, Linus Torvalds, Linux Kernel
Em Sat, Apr 02, 2005 at 01:46:03PM -0600, James Bottomley escreveu:
> Well, this is a brown paper bag for someone. The new protocol
/me using such bag now :(
Thanks a lot for the fix.
David, Please apply.
> registration locking uses a rwlock to limit access to the protocol list.
> Unfortunately, the initialisation:
>
> static rwlock_t proto_list_lock;
>
> Only works to initialise the lock as unlocked on platforms whose unlock
> signal is all zeros. On other platforms, they think it's already locked
> and hang forever.
>
> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
>
>
> ===== net/core/sock.c 1.67 vs edited =====
> --- 1.67/net/core/sock.c 2005-03-26 17:04:35 -06:00
> +++ edited/net/core/sock.c 2005-04-02 13:37:20 -06:00
> @@ -1352,7 +1352,7 @@
>
> EXPORT_SYMBOL(sk_common_release);
>
> -static rwlock_t proto_list_lock;
> +static DEFINE_RWLOCK(proto_list_lock);
> static LIST_HEAD(proto_list);
>
> int proto_register(struct proto *prot, int alloc_slab)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix boot hang on some architectures
2005-04-03 15:21 ` Arnaldo Carvalho de Melo
@ 2005-04-03 21:22 ` David S. Miller
0 siblings, 0 replies; 3+ messages in thread
From: David S. Miller @ 2005-04-03 21:22 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: James.Bottomley, akpm, torvalds, linux-kernel
On Sun, 3 Apr 2005 12:21:01 -0300
Arnaldo Carvalho de Melo <acme@conectiva.com.br> wrote:
> Em Sat, Apr 02, 2005 at 01:46:03PM -0600, James Bottomley escreveu:
> > Well, this is a brown paper bag for someone. The new protocol
>
> /me using such bag now :(
>
> Thanks a lot for the fix.
>
> David, Please apply.
Done, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-04-03 21:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-02 19:46 [PATCH] fix boot hang on some architectures James Bottomley
2005-04-03 15:21 ` Arnaldo Carvalho de Melo
2005-04-03 21:22 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox