* [PATCH -rc2-mm2] update tmpfs for new delete_inode behavior
@ 2005-07-12 14:22 Hugh Dickins
2005-07-12 20:52 ` Mark Fasheh
0 siblings, 1 reply; 2+ messages in thread
From: Hugh Dickins @ 2005-07-12 14:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: Mark Fasheh, linux-kernel
LTP on tmpfs hits kernel BUG at mm/shmem.c:680! shmem_delete_inode needs
to truncate_inode_pages for itself now. It's not immediately obvious since
many cases get covered by shmem_truncate's followup truncate_inode_pages:
maybe with thought we can just call it once, but right now fix the BUG.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
--- 2.6.13-rc2-mm2/mm/shmem.c 2005-07-06 11:23:52.000000000 +0100
+++ linux/mm/shmem.c 2005-07-12 13:58:26.000000000 +0100
@@ -668,6 +668,7 @@ static void shmem_delete_inode(struct in
struct shmem_inode_info *info = SHMEM_I(inode);
if (inode->i_op->truncate == shmem_truncate) {
+ truncate_inode_pages(inode->i_mapping, 0);
shmem_unacct_size(info->flags, inode->i_size);
inode->i_size = 0;
shmem_truncate(inode);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -rc2-mm2] update tmpfs for new delete_inode behavior
2005-07-12 14:22 [PATCH -rc2-mm2] update tmpfs for new delete_inode behavior Hugh Dickins
@ 2005-07-12 20:52 ` Mark Fasheh
0 siblings, 0 replies; 2+ messages in thread
From: Mark Fasheh @ 2005-07-12 20:52 UTC (permalink / raw)
To: Hugh Dickins; +Cc: Andrew Morton, linux-kernel
On Tue, Jul 12, 2005 at 03:22:11PM +0100, Hugh Dickins wrote:
> LTP on tmpfs hits kernel BUG at mm/shmem.c:680! shmem_delete_inode needs
> to truncate_inode_pages for itself now. It's not immediately obvious since
> many cases get covered by shmem_truncate's followup truncate_inode_pages:
> maybe with thought we can just call it once, but right now fix the BUG.
Erf, indeed I missed that one.
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-12 20:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-12 14:22 [PATCH -rc2-mm2] update tmpfs for new delete_inode behavior Hugh Dickins
2005-07-12 20:52 ` Mark Fasheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox