From: Andrew Morton <akpm@osdl.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org, linuxppc64-dev@ozlabs.org
Subject: Re: [PATCH] ppc64: Thermal control for SMU based machines
Date: Tue, 11 Oct 2005 17:03:58 -0700 [thread overview]
Message-ID: <20051011170358.2684347a.akpm@osdl.org> (raw)
In-Reply-To: <1128404215.31063.32.camel@gaston>
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> +int wf_register_client(struct notifier_block *nb)
> +{
> + int rc;
> + struct wf_control *ct;
> + struct wf_sensor *sr;
> +
> + down(&wf_lock);
> + rc = notifier_chain_register(&wf_client_list, nb);
> + if (rc != 0)
> + goto bail;
> + wf_client_count++;
> + list_for_each_entry(ct, &wf_controls, link)
> + wf_notify(WF_EVENT_NEW_CONTROL, ct);
> + list_for_each_entry(sr, &wf_sensors, link)
> + wf_notify(WF_EVENT_NEW_SENSOR, sr);
> + if (wf_client_count == 1)
> + wf_start_thread();
> + up(&wf_lock);
> + bail:
> + return rc;
> +}
This will leave wf_lock held on error.
next prev parent reply other threads:[~2005-10-12 0:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-04 5:36 [PATCH] ppc64: Thermal control for SMU based machines Benjamin Herrenschmidt
2005-10-04 16:44 ` Nish Aravamudan
2005-10-04 21:59 ` Benjamin Herrenschmidt
2005-10-12 0:03 ` Andrew Morton [this message]
2005-10-12 0:20 ` Benjamin Herrenschmidt
2005-10-12 0:10 ` Andrew Morton
2005-10-12 0:23 ` Benjamin Herrenschmidt
2005-10-12 7:34 ` Eric Piel
2005-10-12 7:40 ` Benjamin Herrenschmidt
2005-10-12 0:13 ` Andrew Morton
2005-10-12 0:23 ` Benjamin Herrenschmidt
2005-10-12 0:24 ` Benjamin Herrenschmidt
2005-10-18 20:57 ` linas
2005-10-18 21:23 ` Andrew Morton
[not found] <200511080502.jA852dWI011502@hera.kernel.org>
2005-11-13 17:47 ` Geert Uytterhoeven
2005-11-13 21:00 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051011170358.2684347a.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox