From: Eric Piel <Eric.Piel@tremplin-utc.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linuxppc64-dev@ozlabs.org
Subject: Re: [PATCH] ppc64: Thermal control for SMU based machines
Date: Wed, 12 Oct 2005 09:34:38 +0200 [thread overview]
Message-ID: <434CBC8E.40201@tremplin-utc.net> (raw)
In-Reply-To: <1129076588.17365.245.camel@gaston>
12.10.2005 02:23, Benjamin Herrenschmidt wrote/a écrit:
> On Tue, 2005-10-11 at 17:10 -0700, Andrew Morton wrote:
>
>
>>>+
>>>+ /* Alloc & initialize state */
>>>+ wf_smu_sys_fans = kmalloc(sizeof(struct wf_smu_sys_fans_state),
>>>+ GFP_KERNEL);
>>>+ if (wf_smu_sys_fans == NULL) {
>>>+ printk(KERN_WARNING "windfarm: Memory allocation error"
>>>+ " max fan speed\n");
>>>+ goto fail;
>>>+ }
>>>+ wf_smu_sys_fans->ticks = 1;
>>
>>whitespace broke.
>
>
> How so ? You mean the GFP_KERNEL a little bit too much on the right ? :)
>
I think Andrew was talking about the spaces instead of tabs on the last
line.
Eric
next prev parent reply other threads:[~2005-10-12 7:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-04 5:36 [PATCH] ppc64: Thermal control for SMU based machines Benjamin Herrenschmidt
2005-10-04 16:44 ` Nish Aravamudan
2005-10-04 21:59 ` Benjamin Herrenschmidt
2005-10-12 0:03 ` Andrew Morton
2005-10-12 0:20 ` Benjamin Herrenschmidt
2005-10-12 0:10 ` Andrew Morton
2005-10-12 0:23 ` Benjamin Herrenschmidt
2005-10-12 7:34 ` Eric Piel [this message]
2005-10-12 7:40 ` Benjamin Herrenschmidt
2005-10-12 0:13 ` Andrew Morton
2005-10-12 0:23 ` Benjamin Herrenschmidt
2005-10-12 0:24 ` Benjamin Herrenschmidt
2005-10-18 20:57 ` linas
2005-10-18 21:23 ` Andrew Morton
[not found] <200511080502.jA852dWI011502@hera.kernel.org>
2005-11-13 17:47 ` Geert Uytterhoeven
2005-11-13 21:00 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434CBC8E.40201@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox