From: Andrew Morton <akpm@osdl.org>
To: linas <linas@austin.ibm.com>
Cc: benh@kernel.crashing.org, linuxppc64-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppc64: Thermal control for SMU based machines
Date: Tue, 18 Oct 2005 14:23:57 -0700 [thread overview]
Message-ID: <20051018142357.7eebedfe.akpm@osdl.org> (raw)
In-Reply-To: <20051018205710.GC29826@austin.ibm.com>
linas <linas@austin.ibm.com> wrote:
>
> On Wed, Oct 12, 2005 at 10:24:51AM +1000, Benjamin Herrenschmidt was heard to remark:
> > > > +#define BUILD_SHOW_FUNC_FIX(name, data) \
> > > > +static ssize_t show_##name(struct device *dev, \
> > > > + struct device_attribute *attr, \
> > > > + char *buf) \
> > > > +{ \
> >
> > Ahh no, the problem here is that stupid emacs is very bad with tab
> > and multi-line macros and just turns the whole thing into shit, so
> > I used spaces. Sorry, I'm not an emacs guru and don't know how to
> > work around that ...
>
> Anyone who has tabstops set to 3 instead of 8
wtf? Anyone who has tabstops set to three gets their kernel license revoked.
> will see broken-ness for
> macros like this no matter what. Suggest that the right policy is to use
> only spaces, and neve tabs, inside of macros.
It works OK for everyone else...
next prev parent reply other threads:[~2005-10-18 21:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-04 5:36 [PATCH] ppc64: Thermal control for SMU based machines Benjamin Herrenschmidt
2005-10-04 16:44 ` Nish Aravamudan
2005-10-04 21:59 ` Benjamin Herrenschmidt
2005-10-12 0:03 ` Andrew Morton
2005-10-12 0:20 ` Benjamin Herrenschmidt
2005-10-12 0:10 ` Andrew Morton
2005-10-12 0:23 ` Benjamin Herrenschmidt
2005-10-12 7:34 ` Eric Piel
2005-10-12 7:40 ` Benjamin Herrenschmidt
2005-10-12 0:13 ` Andrew Morton
2005-10-12 0:23 ` Benjamin Herrenschmidt
2005-10-12 0:24 ` Benjamin Herrenschmidt
2005-10-18 20:57 ` linas
2005-10-18 21:23 ` Andrew Morton [this message]
[not found] <200511080502.jA852dWI011502@hera.kernel.org>
2005-11-13 17:47 ` Geert Uytterhoeven
2005-11-13 21:00 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051018142357.7eebedfe.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox