* bugs in /usr/src/linux/net/ipv6/mcast.c
@ 2005-11-16 14:53 Cipriani, Lawrence V (Larry)
2005-11-16 21:02 ` David S. Miller
0 siblings, 1 reply; 5+ messages in thread
From: Cipriani, Lawrence V (Larry) @ 2005-11-16 14:53 UTC (permalink / raw)
To: linux-kernel
/usr/src/linux/net/ipv6/mcast.c: extra semicolon near line 609
if (mc->sfmode == MCAST_INCLUDE && i >= psl->sl_count);
rv = 0;
should be:
if (mc->sfmode == MCAST_EXCLUDE && i >= psl->sl_count)
rv = 0;
/usr/src/linux/net/ipv6/mcast.c: extra semicolon near line 611
if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count);
rv = 0;
should be:
if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count)
rv = 0;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: bugs in /usr/src/linux/net/ipv6/mcast.c
2005-11-16 14:53 bugs in /usr/src/linux/net/ipv6/mcast.c Cipriani, Lawrence V (Larry)
@ 2005-11-16 21:02 ` David S. Miller
0 siblings, 0 replies; 5+ messages in thread
From: David S. Miller @ 2005-11-16 21:02 UTC (permalink / raw)
To: lvc; +Cc: linux-kernel
From: "Cipriani, Lawrence V (Larry)" <lvc@lucent.com>
Date: Wed, 16 Nov 2005 09:53:07 -0500
> /usr/src/linux/net/ipv6/mcast.c: extra semicolon near line 609
> if (mc->sfmode == MCAST_INCLUDE && i >= psl->sl_count);
> rv = 0;
> should be:
> if (mc->sfmode == MCAST_EXCLUDE && i >= psl->sl_count)
> rv = 0;
>
> /usr/src/linux/net/ipv6/mcast.c: extra semicolon near line 611
> if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count);
> rv = 0;
> should be:
> if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count)
> rv = 0;
These have been fixed for a while now in 2.6.x
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: bugs in /usr/src/linux/net/ipv6/mcast.c
@ 2005-11-16 22:24 Cipriani, Lawrence V (Larry)
2005-11-17 13:46 ` Denis Vlasenko
0 siblings, 1 reply; 5+ messages in thread
From: Cipriani, Lawrence V (Larry) @ 2005-11-16 22:24 UTC (permalink / raw)
To: David S. Miller, Cipriani, Lawrence V (Larry); +Cc: linux-kernel
Thanks. We're on 2.4.x For what it's worth, here are a few more I found:
/usr/src/linux/drivers/sound/vidc.c: extra semicolon near line 227
for (new2size = 128; new2size < newsize; new2size <<= 1); !!!
if (new2size - newsize > newsize - (new2size >> 1))
new2size >>= 1;
-----------------------------------------------------------
/usr/src/linux/sound/drivers/serialmidi.c: extra semicolon near line 441
if (serial->sdev); !!!
kfree(serial->sdev);
-----------------------------------------------------------
/usr/src/linux/drivers/s390/misc/chandev.c: extra semicolon near line 2031
if(chandev_find_eligible_channels(curr_chandev,
&read_chandev,
&write_chandev,
&data_chandev,
&next_chandev,
curr_force->chan_type)); !!!
{
-----------------------------------------------------------
/usr/src/linux/drivers/s390/misc/chandev.c: extra semicolong near line 2150
while(!atomic_compare_and_swap(TRUE,FALSE,&chandev_new_msck)); !!!
{
chandev_probe();
}
-----------------------------------------------------------
/usr/src/linux/drivers/s390/block/dasd.c: extra semicolon near line 1528
if (device->discipline->term_IO (cqr) != 0); !!!
cqr->status = CQR_STATUS_FAILED;
-----------------------------------------------------------
/usr/src/linux/drivers/scsi/ide-scsi.c: extra semicolon near line 855
for (id = 0;
id < MAX_HWIFS*MAX_DRIVES && idescsi_drives[id];
id++); !!!
idescsi_setup(drive, scsi, id);
-----------------------------------------------------------
/usr/src/linux/drivers/scsi/osst.c: extra semicolon near line 5264
for (nbr=0; osst_buffers[nbr] != STbuffer && nbr < osst_nbr_buffers; nbr++); !!!
printk(OSST_DEB_MSG
"osst :D: Expanded tape buffer %d (%d bytes, %d->%d segments, dma: %d, a: %p).\n",
nbr, got, STbuffer->orig_sg_segs, STbuffer->sg_segs, need_dma, STbuffer->b_data);
printk(OSST_DEB_MSG
"osst :D: segment sizes: first %d, last %d bytes.\n",
STbuffer->sg[0].length, STbuffer->sg[segs-1].length);
-----------------------------------------------------------
I'm not sure about this one, it sure looks hinky:
/usr/src/linux/abi/svr4/misc.c: extra semicolon near line 564:
for (p = tmp; *p; p++); !!!
p--;
might need to be:
for (p = tmp; *p; p++)
p--;
-----------------------------------------------------------
My C/C++ static analyzer reported several other things too, I'll send them in later.
Larry
-----Original Message-----
From: David S. Miller [mailto:davem@davemloft.net]
Sent: Wednesday, November 16, 2005 4:02 PM
To: lvc@lucent.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: bugs in /usr/src/linux/net/ipv6/mcast.c
From: "Cipriani, Lawrence V (Larry)" <lvc@lucent.com>
Date: Wed, 16 Nov 2005 09:53:07 -0500
> /usr/src/linux/net/ipv6/mcast.c: extra semicolon near line 609
> if (mc->sfmode == MCAST_INCLUDE && i >= psl->sl_count);
> rv = 0;
> should be:
> if (mc->sfmode == MCAST_EXCLUDE && i >= psl->sl_count)
> rv = 0;
>
> /usr/src/linux/net/ipv6/mcast.c: extra semicolon near line 611
> if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count);
> rv = 0;
> should be:
> if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count)
> rv = 0;
These have been fixed for a while now in 2.6.x
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: bugs in /usr/src/linux/net/ipv6/mcast.c
2005-11-16 22:24 Cipriani, Lawrence V (Larry)
@ 2005-11-17 13:46 ` Denis Vlasenko
0 siblings, 0 replies; 5+ messages in thread
From: Denis Vlasenko @ 2005-11-17 13:46 UTC (permalink / raw)
To: Cipriani, Lawrence V (Larry), kai.germaschewski, kkeil,
isdn4linux
Cc: David S. Miller, linux-kernel
On 2.6.14 in drivers/isdn/hisax:
# grep -r '[^a-z0-9_]if *([^()]*([^)]*)[^)]*);' .
./hfc_sx.c: if (Read_hfc(cs, HFCSX_INT_S1));
./hfc_sx.c: if (Read_hfc(cs, HFCSX_INT_S2));
./hfc_sx.c: if (Read_hfc(cs, HFCSX_INT_S1));
./hfc_pci.c: if (Read_hfc(cs, HFCPCI_INT_S1));
./hfc_pci.c: if (Read_hfc(cs, HFCPCI_INT_S1));
./hfc_pci.c: if (Read_hfc(cs, HFCPCI_INT_S1));
These are not bugs, but rather "interesting" coding style:
Write_hfc(cs, HFCSX_INT_M1, cs->hw.hfcsx.int_m1);
/* Clear already pending ints */
if (Read_hfc(cs, HFCSX_INT_S1));
Write_hfc(cs, HFCSX_STATES, HFCSX_LOAD_STATE | 2); /* HFC ST 2 */
Obviously author tried to silence something like lint.
I think it may be replaced with (void)expr; construct.
--
vda
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: bugs in /usr/src/linux/net/ipv6/mcast.c
@ 2005-11-16 22:28 Cipriani, Lawrence V (Larry)
0 siblings, 0 replies; 5+ messages in thread
From: Cipriani, Lawrence V (Larry) @ 2005-11-16 22:28 UTC (permalink / raw)
To: Cipriani, Lawrence V (Larry), 'David S. Miller'
Cc: 'linux-kernel@vger.kernel.org'
Actually on this one
-------------------------------------------------
/usr/src/linux/abi/svr4/misc.c: extra semicolon near line 564:
for (p = tmp; *p; p++); !!!
p--;
It's fine the way it is, it would be easier to read if was this instead
for (p = tmp; *p; p++);
p--;
but no big deal.
-----------------------------------------------------------
Larry
-----Original Message-----
From: David S. Miller [mailto:davem@davemloft.net]
Sent: Wednesday, November 16, 2005 4:02 PM
To: lvc@lucent.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: bugs in /usr/src/linux/net/ipv6/mcast.c
From: "Cipriani, Lawrence V (Larry)" <lvc@lucent.com>
Date: Wed, 16 Nov 2005 09:53:07 -0500
> /usr/src/linux/net/ipv6/mcast.c: extra semicolon near line 609
> if (mc->sfmode == MCAST_INCLUDE && i >= psl->sl_count);
> rv = 0;
> should be:
> if (mc->sfmode == MCAST_EXCLUDE && i >= psl->sl_count)
> rv = 0;
>
> /usr/src/linux/net/ipv6/mcast.c: extra semicolon near line 611
> if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count);
> rv = 0;
> should be:
> if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count)
> rv = 0;
These have been fixed for a while now in 2.6.x
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-11-17 13:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-16 14:53 bugs in /usr/src/linux/net/ipv6/mcast.c Cipriani, Lawrence V (Larry)
2005-11-16 21:02 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2005-11-16 22:24 Cipriani, Lawrence V (Larry)
2005-11-17 13:46 ` Denis Vlasenko
2005-11-16 22:28 Cipriani, Lawrence V (Larry)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox