Re: [2.6 patch] i386: KEXEC must depend on (!SMP && X86_LOCAL_APIC)

[Adrian Bunk <bunk@stusta.de>]

On Wed, Jun 28, 2006 at 11:35:15AM -0600, Eric W. Biederman wrote:
> 
> Adrian Bunk <bunk@stusta.de> writes:
> > This patch fixes the following issue with CONFIG_SMP=y and 
> > CONFIG_X86_VOYAGER=y:
> >
> > <--  snip  -->
> >
> > ...
> >   CC      arch/i386/kernel/crash.o
> > arch/i386/kernel/crash.c: In function ‘crash_nmi_callback’:
> > arch/i386/kernel/crash.c:113: error: implicit declaration of function
> > ‘disable_local_APIC’
> >
> > <--  snip  -->
> 
> I think the patch below more correctly captures the dependency.
> 
> In truth that call to disable_local_APIC() is a bug but the kernel
> isn't ready yet to boot in apic only mode, so it remains until
> the apic initialization can be moved into init_IRQ.
> 
> Does this sound good?

It does compile (I can't test it due to lack of hardware).

> Eric

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed