From: ebiederm@xmission.com (Eric W. Biederman)
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com
Subject: Re: [2.6 patch] i386: KEXEC must depend on (!SMP && X86_LOCAL_APIC)
Date: Wed, 28 Jun 2006 11:35:15 -0600 [thread overview]
Message-ID: <m14py5fajw.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060628165533.GJ13915@stusta.de> (Adrian Bunk's message of "Wed, 28 Jun 2006 18:55:33 +0200")
Adrian Bunk <bunk@stusta.de> writes:
> This patch fixes the following issue with CONFIG_SMP=y and
> CONFIG_X86_VOYAGER=y:
>
> <-- snip -->
>
> ...
> CC arch/i386/kernel/crash.o
> arch/i386/kernel/crash.c: In function ‘crash_nmi_callback’:
> arch/i386/kernel/crash.c:113: error: implicit declaration of function
> ‘disable_local_APIC’
>
> <-- snip -->
I think the patch below more correctly captures the dependency.
In truth that call to disable_local_APIC() is a bug but the kernel
isn't ready yet to boot in apic only mode, so it remains until
the apic initialization can be moved into init_IRQ.
Does this sound good?
Eric
diff --git a/arch/i386/kernel/crash.c b/arch/i386/kernel/crash.c
index 48f0f62..5b96f03 100644
--- a/arch/i386/kernel/crash.c
+++ b/arch/i386/kernel/crash.c
@@ -90,7 +90,7 @@ static void crash_save_self(struct pt_re
crash_save_this_cpu(regs, cpu);
}
-#ifdef CONFIG_SMP
+#if defined(CONFIG_SMP) && defined(CONFIG_X86_LOCAL_APIC)
static atomic_t waiting_for_crash_ipi;
static int crash_nmi_callback(struct pt_regs *regs, int cpu)
next prev parent reply other threads:[~2006-06-28 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 16:55 [2.6 patch] i386: KEXEC must depend on (!SMP && X86_LOCAL_APIC) Adrian Bunk
2006-06-28 17:35 ` Eric W. Biederman [this message]
2006-06-28 20:49 ` Adrian Bunk
2006-06-29 0:40 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m14py5fajw.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox