From: ebiederm@xmission.com (Eric W. Biederman)
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com
Subject: Re: [2.6 patch] i386: KEXEC must depend on (!SMP && X86_LOCAL_APIC)
Date: Wed, 28 Jun 2006 18:40:05 -0600 [thread overview]
Message-ID: <m1sllodcbe.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060628204922.GM13915@stusta.de> (Adrian Bunk's message of "Wed, 28 Jun 2006 22:49:22 +0200")
Adrian Bunk <bunk@stusta.de> writes:
> On Wed, Jun 28, 2006 at 11:35:15AM -0600, Eric W. Biederman wrote:
>>
>> Adrian Bunk <bunk@stusta.de> writes:
>> > This patch fixes the following issue with CONFIG_SMP=y and
>> > CONFIG_X86_VOYAGER=y:
>> >
>> > <-- snip -->
>> >
>> > ...
>> > CC arch/i386/kernel/crash.o
>> > arch/i386/kernel/crash.c: In function ‘crash_nmi_callback’:
>> > arch/i386/kernel/crash.c:113: error: implicit declaration of function
>> > ‘disable_local_APIC’
>> >
>> > <-- snip -->
>>
>> I think the patch below more correctly captures the dependency.
>>
>> In truth that call to disable_local_APIC() is a bug but the kernel
>> isn't ready yet to boot in apic only mode, so it remains until
>> the apic initialization can be moved into init_IRQ.
>>
>> Does this sound good?
>
> It does compile (I can't test it due to lack of hardware).
The code that is disabled is really an optimization to get a higher
quality crash dump so we should be ok.
At the very least it should come very close to working for anyone on
that subarch.
Eric
prev parent reply other threads:[~2006-06-29 0:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 16:55 [2.6 patch] i386: KEXEC must depend on (!SMP && X86_LOCAL_APIC) Adrian Bunk
2006-06-28 17:35 ` Eric W. Biederman
2006-06-28 20:49 ` Adrian Bunk
2006-06-29 0:40 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1sllodcbe.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox