[PATCH] Fix trivial unwind info bug

[PATCH] Fix trivial unwind info bug

[Markus Armbruster]

CFA needs to be adjusted upwards for push, and downwards for pop.
arch/i386/kernel/entry.S gets it wrong in one place.

Signed-off-by: Markus Armbruster <armbru@redhat.com>


diff --git a/arch/i386/kernel/entry.S b/arch/i386/kernel/entry.S
index d9a260f..37a7d2e 100644
--- a/arch/i386/kernel/entry.S
+++ b/arch/i386/kernel/entry.S
@@ -204,7 +204,7 @@ #define RING0_PTREGS_FRAME \
 ENTRY(ret_from_fork)
        CFI_STARTPROC
        pushl %eax
-       CFI_ADJUST_CFA_OFFSET -4
+       CFI_ADJUST_CFA_OFFSET 4
        call schedule_tail
        GET_THREAD_INFO(%ebp)
        popl %eax

Re: [PATCH] Fix trivial unwind info bug

[Andi Kleen]

On Monday 31 July 2006 16:52, Herbert Xu wrote:
> Markus Armbruster <armbru@redhat.com> wrote:
> > CFA needs to be adjusted upwards for push, and downwards for pop.
> > arch/i386/kernel/entry.S gets it wrong in one place.
> >
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Thanks for the patch Markus.  Andi Kleen is now maintaining i386
> so please cc him in future for i386 patches.

Sorry, but that's not true. I do occassional i386 patches, but
overall it is still maintainerless or done by Andrew.

-Andi

Re: [PATCH] Fix trivial unwind info bug

[Herbert Xu]

Markus Armbruster <armbru@redhat.com> wrote:
> CFA needs to be adjusted upwards for push, and downwards for pop.
> arch/i386/kernel/entry.S gets it wrong in one place.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Thanks for the patch Markus.  Andi Kleen is now maintaining i386
so please cc him in future for i386 patches.

> diff --git a/arch/i386/kernel/entry.S b/arch/i386/kernel/entry.S
> index d9a260f..37a7d2e 100644
> --- a/arch/i386/kernel/entry.S
> +++ b/arch/i386/kernel/entry.S
> @@ -204,7 +204,7 @@ #define RING0_PTREGS_FRAME \
> ENTRY(ret_from_fork)
>        CFI_STARTPROC
>        pushl %eax
> -       CFI_ADJUST_CFA_OFFSET -4
> +       CFI_ADJUST_CFA_OFFSET 4
>        call schedule_tail
>        GET_THREAD_INFO(%ebp)
>        popl %eax

I wonder if this is related to the problem of dump_stack() crashing...

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] Fix trivial unwind info bug

[Randy.Dunlap]

On Tue, 01 Aug 2006 00:52:32 +1000 Herbert Xu wrote:

> Markus Armbruster <armbru@redhat.com> wrote:
> > CFA needs to be adjusted upwards for push, and downwards for pop.
> > arch/i386/kernel/entry.S gets it wrong in one place.
> > 
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> 
> Thanks for the patch Markus.  Andi Kleen is now maintaining i386
> so please cc him in future for i386 patches.

Oh, that's clearer than what I heard.  Please add it to
MAINTAINERS.

Thanks,
---
~Randy