* [PATCH] Fix trivial unwind info bug
@ 2006-07-27 5:45 Markus Armbruster
2006-07-31 14:52 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Markus Armbruster @ 2006-07-27 5:45 UTC (permalink / raw)
To: linux-kernel
CFA needs to be adjusted upwards for push, and downwards for pop.
arch/i386/kernel/entry.S gets it wrong in one place.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
diff --git a/arch/i386/kernel/entry.S b/arch/i386/kernel/entry.S
index d9a260f..37a7d2e 100644
--- a/arch/i386/kernel/entry.S
+++ b/arch/i386/kernel/entry.S
@@ -204,7 +204,7 @@ #define RING0_PTREGS_FRAME \
ENTRY(ret_from_fork)
CFI_STARTPROC
pushl %eax
- CFI_ADJUST_CFA_OFFSET -4
+ CFI_ADJUST_CFA_OFFSET 4
call schedule_tail
GET_THREAD_INFO(%ebp)
popl %eax
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Fix trivial unwind info bug
2006-07-27 5:45 [PATCH] Fix trivial unwind info bug Markus Armbruster
@ 2006-07-31 14:52 ` Herbert Xu
2006-07-31 11:23 ` Andi Kleen
2006-07-31 16:25 ` Randy.Dunlap
0 siblings, 2 replies; 4+ messages in thread
From: Herbert Xu @ 2006-07-31 14:52 UTC (permalink / raw)
To: Markus Armbruster, ak; +Cc: linux-kernel
Markus Armbruster <armbru@redhat.com> wrote:
> CFA needs to be adjusted upwards for push, and downwards for pop.
> arch/i386/kernel/entry.S gets it wrong in one place.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Thanks for the patch Markus. Andi Kleen is now maintaining i386
so please cc him in future for i386 patches.
> diff --git a/arch/i386/kernel/entry.S b/arch/i386/kernel/entry.S
> index d9a260f..37a7d2e 100644
> --- a/arch/i386/kernel/entry.S
> +++ b/arch/i386/kernel/entry.S
> @@ -204,7 +204,7 @@ #define RING0_PTREGS_FRAME \
> ENTRY(ret_from_fork)
> CFI_STARTPROC
> pushl %eax
> - CFI_ADJUST_CFA_OFFSET -4
> + CFI_ADJUST_CFA_OFFSET 4
> call schedule_tail
> GET_THREAD_INFO(%ebp)
> popl %eax
I wonder if this is related to the problem of dump_stack() crashing...
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fix trivial unwind info bug
2006-07-31 14:52 ` Herbert Xu
@ 2006-07-31 11:23 ` Andi Kleen
2006-07-31 16:25 ` Randy.Dunlap
1 sibling, 0 replies; 4+ messages in thread
From: Andi Kleen @ 2006-07-31 11:23 UTC (permalink / raw)
To: Herbert Xu; +Cc: Markus Armbruster, linux-kernel
On Monday 31 July 2006 16:52, Herbert Xu wrote:
> Markus Armbruster <armbru@redhat.com> wrote:
> > CFA needs to be adjusted upwards for push, and downwards for pop.
> > arch/i386/kernel/entry.S gets it wrong in one place.
> >
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Thanks for the patch Markus. Andi Kleen is now maintaining i386
> so please cc him in future for i386 patches.
Sorry, but that's not true. I do occassional i386 patches, but
overall it is still maintainerless or done by Andrew.
-Andi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix trivial unwind info bug
2006-07-31 14:52 ` Herbert Xu
2006-07-31 11:23 ` Andi Kleen
@ 2006-07-31 16:25 ` Randy.Dunlap
1 sibling, 0 replies; 4+ messages in thread
From: Randy.Dunlap @ 2006-07-31 16:25 UTC (permalink / raw)
To: Herbert Xu; +Cc: armbru, ak, linux-kernel
On Tue, 01 Aug 2006 00:52:32 +1000 Herbert Xu wrote:
> Markus Armbruster <armbru@redhat.com> wrote:
> > CFA needs to be adjusted upwards for push, and downwards for pop.
> > arch/i386/kernel/entry.S gets it wrong in one place.
> >
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Thanks for the patch Markus. Andi Kleen is now maintaining i386
> so please cc him in future for i386 patches.
Oh, that's clearer than what I heard. Please add it to
MAINTAINERS.
Thanks,
---
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-07-31 18:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-27 5:45 [PATCH] Fix trivial unwind info bug Markus Armbruster
2006-07-31 14:52 ` Herbert Xu
2006-07-31 11:23 ` Andi Kleen
2006-07-31 16:25 ` Randy.Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox