* [PATCH] MPT: make all Fusion MPT sub-choices singly selectable @ 2006-11-25 11:34 Robert P. J. Day 2006-11-25 20:12 ` Randy Dunlap 0 siblings, 1 reply; 5+ messages in thread From: Robert P. J. Day @ 2006-11-25 11:34 UTC (permalink / raw) To: Linux kernel mailing list Put all of the Fusion MPT sub-choices under a single top-level config entry. Signed-off-by: Robert P. J. Day <rpjday@mindspring.com> --- Is there any reason that the sub-choices for Fusion MPT can't be selected or deselected en masse, the way it's done for, say, MTD support and other components? There are other locations where this simplification could be used but I thought I'd wait for some feedback on this example first. diff --git a/drivers/message/fusion/Kconfig b/drivers/message/fusion/Kconfig index ea31d84..a4f0097 100644 --- a/drivers/message/fusion/Kconfig +++ b/drivers/message/fusion/Kconfig @@ -2,13 +2,12 @@ menu "Fusion MPT device support" config FUSION - bool + bool "Fusion MPT device support" default n config FUSION_SPI tristate "Fusion MPT ScsiHost drivers for SPI" - depends on PCI && SCSI - select FUSION + depends on FUSION && PCI && SCSI select SCSI_SPI_ATTRS ---help--- SCSI HOST support for a parallel SCSI host adapters. @@ -22,8 +21,7 @@ config FUSION_SPI config FUSION_FC tristate "Fusion MPT ScsiHost drivers for FC" - depends on PCI && SCSI - select FUSION + depends on FUSION && PCI && SCSI select SCSI_FC_ATTRS ---help--- SCSI HOST support for a Fiber Channel host adapters. @@ -39,8 +37,7 @@ config FUSION_FC config FUSION_SAS tristate "Fusion MPT ScsiHost drivers for SAS" - depends on PCI && SCSI - select FUSION + depends on FUSION && PCI && SCSI select SCSI_SAS_ATTRS ---help--- SCSI HOST support for a SAS host adapters. ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] MPT: make all Fusion MPT sub-choices singly selectable 2006-11-25 11:34 [PATCH] MPT: make all Fusion MPT sub-choices singly selectable Robert P. J. Day @ 2006-11-25 20:12 ` Randy Dunlap 2006-11-25 20:54 ` Robert P. J. Day 2006-11-25 21:22 ` Robert P. J. Day 0 siblings, 2 replies; 5+ messages in thread From: Randy Dunlap @ 2006-11-25 20:12 UTC (permalink / raw) To: Robert P. J. Day; +Cc: Linux kernel mailing list On Sat, 25 Nov 2006 06:34:55 -0500 (EST) Robert P. J. Day wrote: > > Put all of the Fusion MPT sub-choices under a single top-level > config entry. > > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com> > > --- > > Is there any reason that the sub-choices for Fusion MPT can't be > selected or deselected en masse, the way it's done for, say, MTD > support and other components? > > There are other locations where this simplification could be used > but I thought I'd wait for some feedback on this example first. It's an improvement over what is there now. Here's another option. What do you think of it? --- Put all of the Fusion MPT sub-choices under a single top-level config entry. --- Is there any reason that the sub-choices for Fusion MPT can't be selected or deselected en masse, the way it's done for, say, MTD support and other components? There are other locations where this simplification could be used but I thought I'd wait for some feedback on this example first. --- drivers/message/fusion/Kconfig | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) --- linux-2.6.19-rc6-git8.orig/drivers/message/fusion/Kconfig +++ linux-2.6.19-rc6-git8/drivers/message/fusion/Kconfig @@ -1,14 +1,12 @@ -menu "Fusion MPT device support" +menuconfig FUSION + bool "Fusion MPT device support" -config FUSION - bool - default n +if FUSION config FUSION_SPI tristate "Fusion MPT ScsiHost drivers for SPI" depends on PCI && SCSI - select FUSION select SCSI_SPI_ATTRS ---help--- SCSI HOST support for a parallel SCSI host adapters. @@ -23,7 +21,6 @@ config FUSION_SPI config FUSION_FC tristate "Fusion MPT ScsiHost drivers for FC" depends on PCI && SCSI - select FUSION select SCSI_FC_ATTRS ---help--- SCSI HOST support for a Fiber Channel host adapters. @@ -40,7 +37,6 @@ config FUSION_FC config FUSION_SAS tristate "Fusion MPT ScsiHost drivers for SAS" depends on PCI && SCSI - select FUSION select SCSI_SAS_ATTRS ---help--- SCSI HOST support for a SAS host adapters. @@ -54,7 +50,6 @@ config FUSION_SAS config FUSION_MAX_SGE int "Maximum number of scatter gather entries (16 - 128)" - depends on FUSION default "128" range 16 128 help @@ -100,4 +95,4 @@ config FUSION_LAN If unsure whether you really want or need this, say N. -endmenu +endif ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MPT: make all Fusion MPT sub-choices singly selectable 2006-11-25 20:12 ` Randy Dunlap @ 2006-11-25 20:54 ` Robert P. J. Day 2006-11-25 21:44 ` Randy Dunlap 2006-11-25 21:22 ` Robert P. J. Day 1 sibling, 1 reply; 5+ messages in thread From: Robert P. J. Day @ 2006-11-25 20:54 UTC (permalink / raw) To: Randy Dunlap; +Cc: Linux kernel mailing list On Sat, 25 Nov 2006, Randy Dunlap wrote: ... snip ... > Here's another option. What do you think of it? ... > --- linux-2.6.19-rc6-git8.orig/drivers/message/fusion/Kconfig > +++ linux-2.6.19-rc6-git8/drivers/message/fusion/Kconfig > @@ -1,14 +1,12 @@ > > -menu "Fusion MPT device support" > +menuconfig FUSION > + bool "Fusion MPT device support" > > -config FUSION > - bool > - default n > +if FUSION ... more snip ... i suspect you already noticed that that's what i proposed in my followup posting. :-) my first suggestion explicitly didn't mess with the "Device Drivers" menu, only the underlying MPT submenu. my second posting went that extra step and added selection boxes to the Device Drivers menu entries themselves, although your solution is nicer than mine, surrounding the MPT entries with a single "if FUSION" rather than my adding a dependency to every selection. i'm willing to come up with some patches that match your suggestion, but what do others think of changing the fundamental layout of the Device Drivers menu (and perhaps other menus) to that extent by adding that extra selector? rday ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MPT: make all Fusion MPT sub-choices singly selectable 2006-11-25 20:54 ` Robert P. J. Day @ 2006-11-25 21:44 ` Randy Dunlap 0 siblings, 0 replies; 5+ messages in thread From: Randy Dunlap @ 2006-11-25 21:44 UTC (permalink / raw) To: Robert P. J. Day; +Cc: Linux kernel mailing list On Sat, 25 Nov 2006 15:54:18 -0500 (EST) Robert P. J. Day wrote: > On Sat, 25 Nov 2006, Randy Dunlap wrote: > > ... snip ... > > > Here's another option. What do you think of it? > > ... > > > --- linux-2.6.19-rc6-git8.orig/drivers/message/fusion/Kconfig > > +++ linux-2.6.19-rc6-git8/drivers/message/fusion/Kconfig > > @@ -1,14 +1,12 @@ > > > > -menu "Fusion MPT device support" > > +menuconfig FUSION > > + bool "Fusion MPT device support" > > > > -config FUSION > > - bool > > - default n > > +if FUSION > > ... more snip ... > > i suspect you already noticed that that's what i proposed in my > followup posting. :-) my first suggestion explicitly didn't mess > with the "Device Drivers" menu, only the underlying MPT submenu. Actually I had not looked at that email yet -- have now. > my second posting went that extra step and added selection boxes to > the Device Drivers menu entries themselves, although your solution is > nicer than mine, surrounding the MPT entries with a single "if FUSION" > rather than my adding a dependency to every selection. > > i'm willing to come up with some patches that match your suggestion, > but what do others think of changing the fundamental layout of the > Device Drivers menu (and perhaps other menus) to that extent by adding > that extra selector? I like it, but your question to "others" is good. I.e., it would help to have more comments/consensus on this IMO. --- ~Randy ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MPT: make all Fusion MPT sub-choices singly selectable 2006-11-25 20:12 ` Randy Dunlap 2006-11-25 20:54 ` Robert P. J. Day @ 2006-11-25 21:22 ` Robert P. J. Day 1 sibling, 0 replies; 5+ messages in thread From: Robert P. J. Day @ 2006-11-25 21:22 UTC (permalink / raw) To: Randy Dunlap; +Cc: Linux kernel mailing list based on randy's earlier email, here's an updated model for a patch that adds a couple selectors to the Device Drivers menu, one for a boolean MPT, and the other for a tristate MTD. it *seems* to work. (one improvement that *could* be made would be to also edit the MTD sub-Kconfig files and remove their "depends on MTD" clauses since they wouldn't be necessary anymore. but it might be safer to leave those alone just in case someone decides to source those files from elsewhere some day.) again ... thoughts? rday diff --git a/drivers/message/fusion/Kconfig b/drivers/message/fusion/Kconfig index ea31d84..0e4045c 100644 --- a/drivers/message/fusion/Kconfig +++ b/drivers/message/fusion/Kconfig @@ -1,14 +1,12 @@ - -menu "Fusion MPT device support" - -config FUSION - bool +menuconfig FUSION + bool "Fusion MPT device support" default n +if FUSION + config FUSION_SPI tristate "Fusion MPT ScsiHost drivers for SPI" depends on PCI && SCSI - select FUSION select SCSI_SPI_ATTRS ---help--- SCSI HOST support for a parallel SCSI host adapters. @@ -23,7 +21,6 @@ config FUSION_SPI config FUSION_FC tristate "Fusion MPT ScsiHost drivers for FC" depends on PCI && SCSI - select FUSION select SCSI_FC_ATTRS ---help--- SCSI HOST support for a Fiber Channel host adapters. @@ -40,7 +37,6 @@ config FUSION_FC config FUSION_SAS tristate "Fusion MPT ScsiHost drivers for SAS" depends on PCI && SCSI - select FUSION select SCSI_SAS_ATTRS ---help--- SCSI HOST support for a SAS host adapters. @@ -54,7 +50,6 @@ config FUSION_SAS config FUSION_MAX_SGE int "Maximum number of scatter gather entries (16 - 128)" - depends on FUSION default "128" range 16 128 help @@ -100,4 +95,4 @@ config FUSION_LAN If unsure whether you really want or need this, say N. -endmenu +endif diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig index a304b34..dab619b 100644 --- a/drivers/mtd/Kconfig +++ b/drivers/mtd/Kconfig @@ -1,9 +1,7 @@ # $Id: Kconfig,v 1.11 2005/11/07 11:14:19 gleixner Exp $ -menu "Memory Technology Devices (MTD)" - -config MTD - tristate "Memory Technology Device (MTD) support" +menuconfig MTD + tristate "Memory Technology Devices (MTD)" help Memory Technology Devices are flash, RAM and similar chips, often used for solid state file systems on embedded devices. This option @@ -13,9 +11,10 @@ config MTD them. It will also allow you to select individual drivers for particular hardware and users of MTD devices. If unsure, say N. +if MTD + config MTD_DEBUG bool "Debugging" - depends on MTD help This turns on low-level debugging for the entire MTD sub-system. Normally, you should say 'N'. @@ -29,7 +28,6 @@ config MTD_DEBUG_VERBOSE config MTD_CONCAT tristate "MTD concatenating support" - depends on MTD help Support for concatenating several MTD devices into a single (virtual) one. This allows you to have -for example- a JFFS(2) @@ -38,7 +36,6 @@ config MTD_CONCAT config MTD_PARTITIONS bool "MTD partitioning support" - depends on MTD help If you have a device which needs to divide its flash chip(s) up into multiple 'partitions', each of which appears to the user as @@ -153,11 +150,9 @@ config MTD_AFS_PARTS 'armflash' map driver (CONFIG_MTD_ARMFLASH) does this, for example. comment "User Modules And Translation Layers" - depends on MTD config MTD_CHAR tristate "Direct char device access to MTD devices" - depends on MTD help This provides a character device for each MTD device present in the system, allowing the user to read and write directly to the @@ -166,7 +161,7 @@ config MTD_CHAR config MTD_BLOCK tristate "Caching block device access to MTD devices" - depends on MTD && BLOCK + depends on BLOCK ---help--- Although most flash chips have an erase size too large to be useful as block devices, it is possible to use MTD devices which are based @@ -199,7 +194,7 @@ config MTD_BLOCK_RO config FTL tristate "FTL (Flash Translation Layer) support" - depends on MTD && BLOCK + depends on BLOCK ---help--- This provides support for the original Flash Translation Layer which is part of the PCMCIA specification. It uses a kind of pseudo- @@ -215,7 +210,7 @@ config FTL config NFTL tristate "NFTL (NAND Flash Translation Layer) support" - depends on MTD && BLOCK + depends on BLOCK ---help--- This provides support for the NAND Flash Translation Layer which is used on M-Systems' DiskOnChip devices. It uses a kind of pseudo- @@ -238,7 +233,7 @@ config NFTL_RW config INFTL tristate "INFTL (Inverse NAND Flash Translation Layer) support" - depends on MTD && BLOCK + depends on BLOCK ---help--- This provides support for the Inverse NAND Flash Translation Layer which is used on M-Systems' newer DiskOnChip devices. It @@ -255,7 +250,7 @@ config INFTL config RFD_FTL tristate "Resident Flash Disk (Flash Translation Layer) support" - depends on MTD && BLOCK + depends on BLOCK ---help--- This provides support for the flash translation layer known as the Resident Flash Disk (RFD), as used by the Embedded BIOS @@ -265,7 +260,6 @@ config RFD_FTL config SSFDC tristate "NAND SSFDC (SmartMedia) read only translation layer" - depends on MTD default n help This enables read only access to SmartMedia formatted NAND @@ -281,5 +275,5 @@ source "drivers/mtd/nand/Kconfig" source "drivers/mtd/onenand/Kconfig" -endmenu +endif ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-11-25 21:44 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2006-11-25 11:34 [PATCH] MPT: make all Fusion MPT sub-choices singly selectable Robert P. J. Day 2006-11-25 20:12 ` Randy Dunlap 2006-11-25 20:54 ` Robert P. J. Day 2006-11-25 21:44 ` Randy Dunlap 2006-11-25 21:22 ` Robert P. J. Day
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox