* [PATCH] aio: remove bare user-triggerable error printk
@ 2007-03-27 22:44 Zach Brown
2007-03-27 22:49 ` Zach Brown
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Zach Brown @ 2007-03-27 22:44 UTC (permalink / raw)
To: linux-aio, Linus Torvalds, linux-kernel, Jeff Moyer,
Andrew Morton
aio: remove bare user-triggerable error printk
The user can generate console output if they cause do_mmap() to fail during
sys_io_setup(). This was seen in a regression test that does exactly that by
spinning calling mmap() until it gets -ENOMEM before calling io_setup().
We don't need this printk all, just remove it.
Signed-off-by: Zach Brown <zach.brown@oracle.com>
---
fs/aio.c | 1 -
1 file changed, 1 deletion(-)
--- a/fs/aio.c Tue Mar 27 14:56:08 2007 -0700
+++ b/fs/aio.c Tue Mar 27 14:56:49 2007 -0700
@@ -136,7 +136,6 @@ static int aio_setup_ring(struct kioctx
0);
if (IS_ERR((void *)info->mmap_base)) {
up_write(&ctx->mm->mmap_sem);
- printk("mmap err: %ld\n", -info->mmap_base);
info->mmap_size = 0;
aio_free_ring(ctx);
return -EAGAIN;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] aio: remove bare user-triggerable error printk
2007-03-27 22:44 [PATCH] aio: remove bare user-triggerable error printk Zach Brown
@ 2007-03-27 22:49 ` Zach Brown
2007-03-27 23:42 ` Benjamin LaHaise
2007-03-28 13:58 ` Jeff Moyer
2 siblings, 0 replies; 4+ messages in thread
From: Zach Brown @ 2007-03-27 22:49 UTC (permalink / raw)
To: Zach Brown
Cc: linux-aio, Linus Torvalds, linux-kernel, Jeff Moyer,
Andrew Morton
> We don't need this printk all, just remove it.
("at all". Sigh.)
- z
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] aio: remove bare user-triggerable error printk
2007-03-27 22:44 [PATCH] aio: remove bare user-triggerable error printk Zach Brown
2007-03-27 22:49 ` Zach Brown
@ 2007-03-27 23:42 ` Benjamin LaHaise
2007-03-28 13:58 ` Jeff Moyer
2 siblings, 0 replies; 4+ messages in thread
From: Benjamin LaHaise @ 2007-03-27 23:42 UTC (permalink / raw)
To: Zach Brown
Cc: linux-aio, Linus Torvalds, linux-kernel, Jeff Moyer,
Andrew Morton
On Tue, Mar 27, 2007 at 03:44:01PM -0700, Zach Brown wrote:
> The user can generate console output if they cause do_mmap() to fail during
> sys_io_setup(). This was seen in a regression test that does exactly that by
> spinning calling mmap() until it gets -ENOMEM before calling io_setup().
>
> We don't need this printk all, just remove it.
>
> Signed-off-by: Zach Brown <zach.brown@oracle.com>
Yes. Please!
Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <zyntrop@kvack.org>.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] aio: remove bare user-triggerable error printk
2007-03-27 22:44 [PATCH] aio: remove bare user-triggerable error printk Zach Brown
2007-03-27 22:49 ` Zach Brown
2007-03-27 23:42 ` Benjamin LaHaise
@ 2007-03-28 13:58 ` Jeff Moyer
2 siblings, 0 replies; 4+ messages in thread
From: Jeff Moyer @ 2007-03-28 13:58 UTC (permalink / raw)
To: Zach Brown; +Cc: linux-aio, Linus Torvalds, linux-kernel, Andrew Morton
==> On Tue, 27 Mar 2007 15:44:01 -0700 (PDT), Zach Brown <zach.brown@oracle.com> said:
Zach> aio: remove bare user-triggerable error printk The user can
Zach> generate console output if they cause do_mmap() to fail during
Zach> sys_io_setup(). This was seen in a regression test that does
Zach> exactly that by spinning calling mmap() until it gets -ENOMEM
Zach> before calling io_setup().
Zach> We don't need this printk all, just remove it.
ACK.
Zach> Signed-off-by: Zach Brown <zach.brown@oracle.com> ---
Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
-Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-03-28 13:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-27 22:44 [PATCH] aio: remove bare user-triggerable error printk Zach Brown
2007-03-27 22:49 ` Zach Brown
2007-03-27 23:42 ` Benjamin LaHaise
2007-03-28 13:58 ` Jeff Moyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox