* [Patch][SIS USB2VGA] Warning fix
@ 2007-05-03 5:34 WANG Cong
2007-05-03 5:48 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: WANG Cong @ 2007-05-03 5:34 UTC (permalink / raw)
To: thomas, akpm; +Cc: LKML, Wang Ya-gang, Chen Li-jun
Fix this warning:
drivers/usb/misc/sisusbvga/sisusb_con.c:1436: warning: initialization from incompatible pointer type
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
---
Compiling test past.;)
--- linux-2.6.21-rc7-mm2/drivers/usb/misc/sisusbvga/sisusb_con.c.orig 2007-05-03 02:51:06.000000000 +0800
+++ linux-2.6.21-rc7-mm2/drivers/usb/misc/sisusbvga/sisusb_con.c 2007-05-03 02:57:08.000000000 +0800
@@ -321,9 +321,10 @@ sisusbcon_deinit(struct vc_data *c)
/* interface routine */
static u8
sisusbcon_build_attr(struct vc_data *c, u8 color, u8 intensity,
- u8 blink, u8 underline, u8 reverse)
+ u8 blink, u8 underline, u8 reverse, u8 unused)
{
u8 attr = color;
+ (void) unused;
if (underline)
attr = (attr & 0xf0) | c->vc_ulcolor;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Patch][SIS USB2VGA] Warning fix
2007-05-03 5:34 [Patch][SIS USB2VGA] Warning fix WANG Cong
@ 2007-05-03 5:48 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2007-05-03 5:48 UTC (permalink / raw)
To: WANG Cong; +Cc: thomas, LKML, Wang Ya-gang, Chen Li-jun
On Thu, 3 May 2007 13:34:29 +0800 WANG Cong <xiyou.wangcong@gmail.com> wrote:
>
> Fix this warning:
> drivers/usb/misc/sisusbvga/sisusb_con.c:1436: warning: initialization from incompatible pointer type
>
>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
> ---
>
> Compiling test past.;)
>
Thanks.
> --- linux-2.6.21-rc7-mm2/drivers/usb/misc/sisusbvga/sisusb_con.c.orig 2007-05-03 02:51:06.000000000 +0800
> +++ linux-2.6.21-rc7-mm2/drivers/usb/misc/sisusbvga/sisusb_con.c 2007-05-03 02:57:08.000000000 +0800
> @@ -321,9 +321,10 @@ sisusbcon_deinit(struct vc_data *c)
> /* interface routine */
> static u8
> sisusbcon_build_attr(struct vc_data *c, u8 color, u8 intensity,
> - u8 blink, u8 underline, u8 reverse)
> + u8 blink, u8 underline, u8 reverse, u8 unused)
> {
> u8 attr = color;
> + (void) unused;
This part isn't needed and we don't usually do it - the compiler will not warn
about the unused arg.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-03 5:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-03 5:34 [Patch][SIS USB2VGA] Warning fix WANG Cong
2007-05-03 5:48 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox