From: Ingo Molnar <mingo@elte.hu>
To: Bill Huey <billh@gnuppy.monkey.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, Jason Baron <jbaron@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] lockdep: lock contention tracking
Date: Mon, 21 May 2007 11:36:39 +0200 [thread overview]
Message-ID: <20070521093639.GA29025@elte.hu> (raw)
In-Reply-To: <20070521091848.GB4593@gnuppy.monkey.org>
* Bill Huey <billh@gnuppy.monkey.org> wrote:
> I write lockstat without the knowledge that lockdep was replicating
> the same work and I audited 1600 something lock points in the kernel
> to convert the usage of C99 style initializers to something more
> regular.
you got the history wrong i think: the first version of lockdep was
released to lkml a year ago (May 2006), while the first time you
mentioned your lock contention patch was November 2006 and you released
it to lkml in December 2006 - so it was _you_ who was "replicating the
same work", not lockdep :-) And this was pointed out to you very early
on, many months ago.
and regarding C99 style lock initializers: the -rt project has been
removing a whole heap of them in the past 2.5 years, since Oct 2004 or
so, and regularly cleansed the upstream kernel for old-style
initializers ever since then - so i'm not sure what you are referring
to.
> I also did this without consideration of things like debuginfo since I
> don't use those things.
btw., you dont even need CONFIG_DEBUG_INFO to get usable symbol names,
CONFIG_KALLSYMS alone will do it too. (It's only if you really cannot
tell from the lock symbol name and the function name what the entry is
about - which is very rare - that you need to look at any debug-info)
Ingo
next prev parent reply other threads:[~2007-05-21 9:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-20 10:30 [PATCH] lockdep: lock contention tracking Peter Zijlstra
2007-05-20 18:05 ` Ingo Molnar
2007-05-21 6:04 ` Bill Huey
2007-05-21 6:08 ` Ingo Molnar
2007-05-21 6:41 ` Bill Huey
2007-05-21 7:50 ` Ingo Molnar
2007-05-21 9:18 ` Bill Huey
2007-05-21 9:36 ` Ingo Molnar [this message]
2007-05-21 9:55 ` Christoph Hellwig
2007-05-21 10:21 ` Bill Huey
2007-05-21 10:58 ` Ingo Molnar
2007-05-21 19:17 ` Bill Huey
2007-05-21 10:19 ` Bill Huey
2007-05-21 10:28 ` Bill Huey
2007-05-21 12:46 ` Ingo Molnar
2007-05-21 19:09 ` Bill Huey
2007-05-21 20:58 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070521093639.GA29025@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=billh@gnuppy.monkey.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox