[PATCH 2/2] I8K: Adds i8k driver to the x86_64 Kconfig

[PATCH 2/2] I8K: Adds i8k driver to the x86_64 Kconfig

[Bradley Smith]

From: Bradley Smith <bradjsmith@btinternet.com>

Adds i8k driver to the x86_64 Kconfig.

Signed-off-by: Bradley Smith <bradjsmith@btinternet.com>

---

Only applies on kernels >= 2.6.24.
Depends on "[PATCH 1/2] I8K: Allow i8k driver to be built on x86_64 systems"

--- linux-2.6/arch/x86/Kconfig.x86_64.orig	2007-10-28 14:04:13.000000000 +0000
+++ linux-2.6/arch/x86/Kconfig.x86_64	2007-10-28 13:59:06.000000000 +0000
@@ -224,6 +224,26 @@ config X86_GOOD_APIC
 	bool
 	default y
 
+config I8K
+	tristate "Dell laptop support"
+	---help---
+	  This adds a driver to safely access the System Management Mode
+	  of the CPU on the Dell Inspiron 8000. The System Management Mode
+	  is used to read cpu temperature and cooling fan status and to
+	  control the fans on the I8K portables.
+
+	  This driver has been tested only on the Inspiron 8000 but it may
+	  also work with other Dell laptops. You can force loading on other
+	  models by passing the parameter `force=1' to the module. Use at
+	  your own risk.
+
+	  For information on utilities to make use of this driver see the
+	  I8K Linux utilities web site at:
+	  <http://people.debian.org/~dz/i8k/>
+
+	  Say Y if you intend to run this kernel on a Dell Inspiron 8000.
+	  Say N otherwise.
+
 config MICROCODE
 	tristate "/dev/cpu/microcode - Intel CPU microcode support"
 	select FW_LOADER

Re: [PATCH 2/2] I8K: Adds i8k driver to the x86_64 Kconfig

[Frans Pop]

Bradley Smith wrote:
> +config I8K
> +     tristate "Dell laptop support"

Shouldn't that be config DELL_I8K, or even DELL_INSPIRON_8K?

Cheers,
Frans Pop

Re: [PATCH 2/2] I8K: Adds i8k driver to the x86_64 Kconfig

[Bradley Smith]

On Sun, 28 Oct 2007 18:46:40 +0100
Frans Pop <elendil@planet.nl> wrote:

> Bradley Smith wrote:
> > +config I8K
> > +     tristate "Dell laptop support"
> 
> Shouldn't that be config DELL_I8K, or even DELL_INSPIRON_8K?
> 
> Cheers,
> Frans Pop

I was going by linux-2.6/arch/x86/Kconfig.i386, which has "config I8K" but maybe it should be
changed...

Brad.

Re: [PATCH 2/2] I8K: Adds i8k driver to the x86_64 Kconfig

[Andrew Morton]

On Sun, 28 Oct 2007 17:26:13 +0000
Bradley Smith <bradjsmith@btinternet.com> wrote:

> From: Bradley Smith <bradjsmith@btinternet.com>
> 
> Adds i8k driver to the x86_64 Kconfig.
> 
> Signed-off-by: Bradley Smith <bradjsmith@btinternet.com>
> 
> ---
> 
> Only applies on kernels >= 2.6.24.
> Depends on "[PATCH 1/2] I8K: Allow i8k driver to be built on x86_64 systems"
> 
> --- linux-2.6/arch/x86/Kconfig.x86_64.orig	2007-10-28 14:04:13.000000000 +0000
> +++ linux-2.6/arch/x86/Kconfig.x86_64	2007-10-28 13:59:06.000000000 +0000
> @@ -224,6 +224,26 @@ config X86_GOOD_APIC
>  	bool
>  	default y
>  
> +config I8K
> +	tristate "Dell laptop support"
> +	---help---
> +	  This adds a driver to safely access the System Management Mode
> +	  of the CPU on the Dell Inspiron 8000. The System Management Mode
> +	  is used to read cpu temperature and cooling fan status and to
> +	  control the fans on the I8K portables.
> +
> +	  This driver has been tested only on the Inspiron 8000 but it may
> +	  also work with other Dell laptops. You can force loading on other
> +	  models by passing the parameter `force=1' to the module. Use at
> +	  your own risk.
> +
> +	  For information on utilities to make use of this driver see the
> +	  I8K Linux utilities web site at:
> +	  <http://people.debian.org/~dz/i8k/>
> +
> +	  Say Y if you intend to run this kernel on a Dell Inspiron 8000.
> +	  Say N otherwise.
> +
>  config MICROCODE
>  	tristate "/dev/cpu/microcode - Intel CPU microcode support"
>  	select FW_LOADER

The i386 and x86_64 Kconfig files just got unified, so this patch became
agreeably simpler:



--- a/arch/x86/Kconfig~i8k-adds-i8k-driver-to-the-x86_64-kconfig
+++ a/arch/x86/Kconfig
@@ -641,7 +641,6 @@ config TOSHIBA
 
 config I8K
 	tristate "Dell laptop support"
-	depends on X86_32
 	---help---
 	  This adds a driver to safely access the System Management Mode
 	  of the CPU on the Dell Inspiron 8000. The System Management Mode
_