From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
linux-kernel@vger.kernel.org
Subject: Re: Linux 2.6.24-rc5 x86 architecture no longer Oopses...
Date: Fri, 21 Dec 2007 00:47:59 +0100 [thread overview]
Message-ID: <20071220234759.GA29776@elte.hu> (raw)
In-Reply-To: <20071220145415.f737e7f3.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> Yes - I don't know why the smp_processor_id() test has suddenly
> started triggering in there.
it's a "must not happen".
here:
> __raw_spin_lock(&die.lock);
> raw_local_save_flags(flags);
> - die.lock_owner = smp_processor_id();
> + die.lock_owner = raw_smp_processor_id();
we just disabled irqs with raw_local_save_flags().
here:
> mem_parity_error(unsigned char reason, struct pt_regs * regs)
> {
> printk(KERN_EMERG "Uhhuh. NMI received for unknown reason %02x on "
> - "CPU %d.\n", reason, smp_processor_id());
> + "CPU %d.\n", reason, raw_smp_processor_id());
> printk(KERN_EMERG "You have some hardware problem, likely on the PCI bus.\n");
we are straight into an NMI which has hardirqs disabled.
> printk(KERN_EMERG "Uhhuh. NMI received for unknown reason %02x on "
> - "CPU %d.\n", reason, smp_processor_id());
> + "CPU %d.\n", reason, raw_smp_processor_id());
ditto.
> @@ -708,7 +708,7 @@ void __kprobes die_nmi(struct pt_regs *r
> bust_spinlocks(1);
> printk(KERN_EMERG "%s", msg);
> printk(" on CPU%d, ip %08lx, registers:\n",
> - smp_processor_id(), regs->ip);
> + raw_smp_processor_id(), regs->ip);
same.
it needs to be found out why the preempt_count suddenly went to zero. Is
task struct corruption out of question?
Ingo
next prev parent reply other threads:[~2007-12-20 23:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 22:40 Linux 2.6.24-rc5 x86 architecture no longer Oopses Trond Myklebust
2007-12-20 22:54 ` Andrew Morton
2007-12-20 22:56 ` Andrew Morton
2007-12-20 23:06 ` Trond Myklebust
2007-12-21 0:55 ` Rafael J. Wysocki
2007-12-21 10:19 ` Ingo Molnar
2007-12-20 23:04 ` Trond Myklebust
2007-12-20 23:47 ` Ingo Molnar [this message]
2007-12-21 0:02 ` Andrew Morton
2007-12-21 0:05 ` Ingo Molnar
2007-12-21 0:19 ` Andrew Morton
2007-12-21 0:30 ` Ingo Molnar
2007-12-21 0:40 ` Andrew Morton
2007-12-21 0:44 ` Ingo Molnar
2007-12-21 10:27 ` Ingo Molnar
2007-12-21 10:42 ` Andrew Morton
2007-12-21 11:12 ` Ingo Molnar
2007-12-21 11:34 ` Andrew Morton
2007-12-21 12:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220234759.GA29776@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox