From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: trond.myklebust@fys.uio.no, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.6.24-rc5 x86 architecture no longer Oopses...
Date: Fri, 21 Dec 2007 12:12:07 +0100 [thread overview]
Message-ID: <20071221111207.GC29047@elte.hu> (raw)
In-Reply-To: <20071221024211.f4207136.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> I'd suggest that we add a local_read_flags() along with
> local_save_flags(). Then I can merge the parts of the patch which
> don't get destroyed by ongoing churn and then we can come in and clean
> up the stragglers later.
ah, indeed.
like the patch below? (Only local_save_flags() should be used by drivers
- but i stuck in the other variants as well for completeness.)
Ingo
-------------------->
Subject: migration helpers for local_save_flags => local_read_flags rename
From: Ingo Molnar <mingo@elte.hu>
prepare for renaming of all local_save_flags variants to local_read_flags,
via migration helpers, as suggested by Andrew Morton.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
include/linux/irqflags.h | 9 +++++++++
1 file changed, 9 insertions(+)
Index: linux-x86.q/include/linux/irqflags.h
===================================================================
--- linux-x86.q.orig/include/linux/irqflags.h
+++ linux-x86.q/include/linux/irqflags.h
@@ -93,4 +93,13 @@
#define irqs_disabled_flags(flags) raw_irqs_disabled_flags(flags)
#endif /* CONFIG_X86 */
+/*
+ * Migration helpers - the proper API is the local_read_flags API.
+ * Will go away in v2.6.26.
+ */
+#define local_save_flags local_read_flags
+#define __local_save_flags __local_read_flags
+#define raw_local_save_flags raw_local_read_flags
+#define __raw_local_save_flags __raw_local_read_flags
+
#endif
next prev parent reply other threads:[~2007-12-21 11:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 22:40 Linux 2.6.24-rc5 x86 architecture no longer Oopses Trond Myklebust
2007-12-20 22:54 ` Andrew Morton
2007-12-20 22:56 ` Andrew Morton
2007-12-20 23:06 ` Trond Myklebust
2007-12-21 0:55 ` Rafael J. Wysocki
2007-12-21 10:19 ` Ingo Molnar
2007-12-20 23:04 ` Trond Myklebust
2007-12-20 23:47 ` Ingo Molnar
2007-12-21 0:02 ` Andrew Morton
2007-12-21 0:05 ` Ingo Molnar
2007-12-21 0:19 ` Andrew Morton
2007-12-21 0:30 ` Ingo Molnar
2007-12-21 0:40 ` Andrew Morton
2007-12-21 0:44 ` Ingo Molnar
2007-12-21 10:27 ` Ingo Molnar
2007-12-21 10:42 ` Andrew Morton
2007-12-21 11:12 ` Ingo Molnar [this message]
2007-12-21 11:34 ` Andrew Morton
2007-12-21 12:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071221111207.GC29047@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox