From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [x86] get rid of checkpatch.pl complains on apm_32.c
Date: Tue, 1 Jan 2008 16:00:54 +0100 [thread overview]
Message-ID: <20080101150054.GB4434@elte.hu> (raw)
In-Reply-To: <20071231204753.GA7411@cvg.cvg>
* Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> This patch eliminates most of code-style errors discovered by
> checkpatch.pl on arch/x86/kernel/apm_32.c
looks good in principle, but the patch is not a NOP:
text data bss dec hex filename
12142 1837 84 14063 36ef apm_32.o.before
12141 1837 84 14062 36ee apm_32.o.after
md5:
2676b881ad55e387da4a995e8b9ee372 apm_32.o.before.asm
7fcce83dca90ded66cc43f9b4d4ca2d2 apm_32.o.after.asm
cleanup patches should not change the resulting object code. The change
is due to this hunk:
@@ -1918,8 +1940,9 @@ static int __init apm_is_horked_d850md(c
{
if (apm_info.disabled == 0) {
apm_info.disabled = 1;
- printk(KERN_INFO "%s machine detected. Disabling APM.\n", d->ident);
- printk(KERN_INFO "This bug is fixed in bios P15 which is available for \n");
+ printk(KERN_INFO "%s machine detected. "
+ "Disabling APM.\n", d->ident);
+ printk(KERN_INFO "This bug is fixed in bios P15 which is available for\n");
printk(KERN_INFO "download from support.intel.com \n");
}
return 0;
the "for \n" has been changed to "for\n". Which is an OK cleanup, but
please do such material changes in separate patches in the future. (we
can accept and review cleanup patches that are NOPs much easier and
faster)
so i removed that string change and applied your patch to x86.git, which
is now a nice NOP:
text data bss dec hex filename
12142 1837 84 14063 36ef apm_32.o.before
12142 1837 84 14063 36ef apm_32.o.after
md5:
2676b881ad55e387da4a995e8b9ee372 apm_32.o.before.asm
2676b881ad55e387da4a995e8b9ee372 apm_32.o.after.asm
Ingo
next prev parent reply other threads:[~2008-01-01 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-31 20:47 [x86] get rid of checkpatch.pl complains on apm_32.c Cyrill Gorcunov
2008-01-01 15:00 ` Ingo Molnar [this message]
2008-01-01 15:11 ` Cyrill Gorcunov
2008-01-01 15:29 ` Ingo Molnar
2008-01-01 15:34 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080101150054.GB4434@elte.hu \
--to=mingo@elte.hu \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox