From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [x86] get rid of checkpatch.pl complains on apm_32.c
Date: Tue, 1 Jan 2008 16:29:31 +0100 [thread overview]
Message-ID: <20080101152931.GH4434@elte.hu> (raw)
In-Reply-To: <20080101151112.GC7937@cvg.cvg>
* Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> damn me! *really* sorry for this.
nah, this happens all the time for me too - that's why i run a script
over cleanup patches.
> Ingo, do you use some script for this checking? if yes - could you
> share it? ;) (i think it's not really hard to write myown, but your
> one is really preferred ;)
sure, pick up the script from:
http://redhat.com/~mingo/misc/q-size-obj-compare
it depends on having the patch in a quilt queue. (and it's really sucky,
no error checking, etc.)
just run it - it picks up a modified .c file and compares that. If you
modify multiple files and want to check another one, give that file as
an argument to the script.
Ingo
next prev parent reply other threads:[~2008-01-01 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-31 20:47 [x86] get rid of checkpatch.pl complains on apm_32.c Cyrill Gorcunov
2008-01-01 15:00 ` Ingo Molnar
2008-01-01 15:11 ` Cyrill Gorcunov
2008-01-01 15:29 ` Ingo Molnar [this message]
2008-01-01 15:34 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080101152931.GH4434@elte.hu \
--to=mingo@elte.hu \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox