From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [x86] get rid of checkpatch.pl complains on apm_32.c
Date: Tue, 1 Jan 2008 18:34:24 +0300 [thread overview]
Message-ID: <20080101153424.GF7937@cvg.cvg> (raw)
In-Reply-To: <20080101152931.GH4434@elte.hu>
[Ingo Molnar - Tue, Jan 01, 2008 at 04:29:31PM +0100]
|
| * Cyrill Gorcunov <gorcunov@gmail.com> wrote:
|
| > damn me! *really* sorry for this.
|
| nah, this happens all the time for me too - that's why i run a script
| over cleanup patches.
|
yep, but i don't want to put additional work on developers so i must
review the patches i'm sending *several* times at least! so that is my
fault ;)
| > Ingo, do you use some script for this checking? if yes - could you
| > share it? ;) (i think it's not really hard to write myown, but your
| > one is really preferred ;)
|
| sure, pick up the script from:
|
| http://redhat.com/~mingo/misc/q-size-obj-compare
|
| it depends on having the patch in a quilt queue. (and it's really sucky,
| no error checking, etc.)
|
| just run it - it picks up a modified .c file and compares that. If you
| modify multiple files and want to check another one, give that file as
| an argument to the script.
|
| Ingo
|
thanks, Ingo.
- Cyrill -
prev parent reply other threads:[~2008-01-01 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-31 20:47 [x86] get rid of checkpatch.pl complains on apm_32.c Cyrill Gorcunov
2008-01-01 15:00 ` Ingo Molnar
2008-01-01 15:11 ` Cyrill Gorcunov
2008-01-01 15:29 ` Ingo Molnar
2008-01-01 15:34 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080101153424.GF7937@cvg.cvg \
--to=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox