public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	linux-pci@atrey.karlin.mff.cuni.cz,
	LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>,
	Tejun Heo <htejun@gmail.com>,
	Tom Long Nguyen <tom.l.nguyen@intel.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Jeff Garzik <jgarzik@pobox.com>
Subject: Re: PCI MSI breaks when booting with nosmp
Date: Tue, 22 Apr 2008 15:27:02 +0200	[thread overview]
Message-ID: <200804221527.03169.jdelvare@suse.de> (raw)
In-Reply-To: <200804211414.45629.jbarnes@virtuousgeek.org>

Hi Jesse,

Le lundi 21 avril 2008, Jesse Barnes a écrit :
> This might be closer to a real fix.  Can you confirm that this works for you 
> Jean?
> 
> Thanks,
> Jesse
> 
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index e6abe8a..7cdf930 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -1138,14 +1138,10 @@ static int __init smp_sanity_check(unsigned max_cpus)
>  				 "forcing use of dummy APIC emulation.\n");
>  		smpboot_clear_io_apic();
>  #ifdef CONFIG_X86_32
> -		if (nmi_watchdog == NMI_LOCAL_APIC) {
> -			printk(KERN_INFO "activating minimal APIC for"
> -					 "NMI watchdog use.\n");
> -			connect_bsp_APIC();
> -			setup_local_APIC();
> -			end_local_APIC_setup();
> -		}
> +		connect_bsp_APIC();
>  #endif
> +		setup_local_APIC();
> +		end_local_APIC_setup();
>  		return -1;
>  	}
>  
> 

What tree is this patch against? I have no arch/x86/kernel/smpboot.c
in 2.6.25.

-- 
Jean Delvare
Suse L3

  reply	other threads:[~2008-04-22 13:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17 19:40 PCI MSI breaks when booting with nosmp Jean Delvare
2008-04-17 20:08 ` Jesse Barnes
2008-04-17 20:25   ` Jean Delvare
2008-04-21 17:43     ` Jesse Barnes
2008-04-21 18:45       ` Andi Kleen
2008-04-21 19:06         ` Jesse Barnes
2008-04-21 19:35           ` Jesse Barnes
2008-04-21 19:41           ` Andi Kleen
2008-04-21 19:43         ` Pavel Machek
2008-04-21 19:44           ` Andi Kleen
2008-04-22 21:25             ` Pavel Machek
2008-04-22 23:07               ` Jesse Barnes
2008-04-21 20:20         ` Jean Delvare
2008-04-21 20:40           ` Jesse Barnes
2008-04-21 20:46           ` Andi Kleen
2008-04-21 20:48             ` Jean Delvare
2008-04-21 21:09               ` Andi Kleen
2008-04-21 21:14                 ` Jesse Barnes
2008-04-22 13:27                   ` Jean Delvare [this message]
2008-04-22 15:50                     ` Jesse Barnes
2008-04-23 14:38                   ` Jean Delvare
2008-04-23 15:12                     ` Jesse Barnes
2008-04-23 18:13                       ` Maciej W. Rozycki
2008-04-23 18:23                         ` Jesse Barnes
2008-04-23 18:32                           ` Jesse Barnes
2008-04-23 18:32                           ` Jean Delvare
2008-04-23 18:38                           ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804221527.03169.jdelvare@suse.de \
    --to=jdelvare@suse.de \
    --cc=andi@firstfloor.org \
    --cc=htejun@gmail.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=pavel@ucw.cz \
    --cc=rdunlap@xenotime.net \
    --cc=tom.l.nguyen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox