no help text for DVB_TUNER_ITD1000

no help text for DVB_TUNER_ITD1000

[Adrian Bunk]

The DVB_TUNER_ITD1000 option introduced by
commit 1881ee89e0fe03ac5bba9045acb3bea1818f9466
(V4L/DVB (7571): mt312: Cleanup buffer variables of read/write functions)
lacks a help text.

Please add a help text.

Thanks in advance
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: no help text for DVB_TUNER_ITD1000

[Mauro Carvalho Chehab]

Hi Adrian,

On Thu, 24 Apr 2008 23:22:57 +0300
Adrian Bunk <bunk@kernel.org> wrote:

> The DVB_TUNER_ITD1000 option introduced by
> commit 1881ee89e0fe03ac5bba9045acb3bea1818f9466
> (V4L/DVB (7571): mt312: Cleanup buffer variables of read/write functions)
> lacks a help text.
> 
> Please add a help text.

Thanks for pointing.

I just noticed and prepared a patch. I should soon add it to devel branch
at -git for people to review. 

Yet, I think we should visit drivers/media/dvb/frontends/Kconfig. There are
lots of "help" there that, IMO, are asking for improvements.

Cheers,
Mauro

Re: [v4l-dvb-maintainer] no help text for DVB_TUNER_ITD1000

[Brandon Philips]

On 17:28 Thu 24 Apr 2008, Mauro Carvalho Chehab wrote:
> On Thu, 24 Apr 2008 23:22:57 +0300 Adrian Bunk <bunk@kernel.org> wrote:
> > The DVB_TUNER_ITD1000 option introduced by
> > commit 1881ee89e0fe03ac5bba9045acb3bea1818f9466
> > (V4L/DVB (7571): mt312: Cleanup buffer variables of read/write functions)
> > lacks a help text.
> > 
> > Please add a help text.
> 
> Thanks for pointing.
> 
> I just noticed and prepared a patch. I should soon add it to devel branch
> at -git for people to review. 

How is adding this Kconfig related to the patch that Matthias posted?
Once again, some very strange folding is happening as things are moving
into git.

http://article.gmane.org/gmane.linux.drivers.dvb/41017/match=mt312+cleanup+buffer+variables+read+write+functions

vs.

http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commitdiff;h=1881ee89e0fe03ac5bba9045acb3bea1818f9466;hp=dbad108bdcb30629c850f5606949510da010a686

Could I take a look at the scripts that are used to generate the git
tree?  This is the second time in the last few weeks that something like
this has happened.

Cheers,

	Brandon

Re: [v4l-dvb-maintainer] no help text for DVB_TUNER_ITD1000

[Mauro Carvalho Chehab]

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]

On Thu, 24 Apr 2008 14:08:21 -0700
Brandon Philips <bphilips@suse.de> wrote:

> On 17:28 Thu 24 Apr 2008, Mauro Carvalho Chehab wrote:
> > On Thu, 24 Apr 2008 23:22:57 +0300 Adrian Bunk <bunk@kernel.org> wrote:
> > > The DVB_TUNER_ITD1000 option introduced by
> > > commit 1881ee89e0fe03ac5bba9045acb3bea1818f9466
> > > (V4L/DVB (7571): mt312: Cleanup buffer variables of read/write functions)
> > > lacks a help text.
> > > 
> > > Please add a help text.
> > 
> > Thanks for pointing.
> > 
> > I just noticed and prepared a patch. I should soon add it to devel branch
> > at -git for people to review. 
> 
> How is adding this Kconfig related to the patch that Matthias posted?
> Once again, some very strange folding is happening as things are moving
> into git.
> 
> http://article.gmane.org/gmane.linux.drivers.dvb/41017/match=mt312+cleanup+buffer+variables+read+write+functions
> 
> vs.
> 
> http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commitdiff;h=1881ee89e0fe03ac5bba9045acb3bea1818f9466;hp=dbad108bdcb30629c850f5606949510da010a686

Argh!

Matthias, sorry for the mess.

> Could I take a look at the scripts that are used to generate the git
> tree?  This is the second time in the last few weeks that something like
> this has happened.

This error weren't generated by the script. The enclosed patch is the resulting patch
from the scripts. It is the correct one.

I'll investigate what's happened here, and do some git integrity checks. Maybe
stgit did something bad.

Cheers,
Mauro

[-- Attachment #2: v4l_dvb_hg_7571_mt312_cleanup_buffer_variables_of_read_write_functions.patch --]
[-- Type: text/x-patch, Size: 2150 bytes --]

Changeset: 7571
From: Matthias Schwarzott  <zzam@gentoo.org>
Commiter: Mauro Carvalho Chehab <mchehab@infradead.org>
Date: Sat Apr 12 15:04:46 2008 +0000
Subject: mt312: Cleanup buffer variables of read/write functions

Change type of buffer variables from void* to u8* to save some casts.

Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

diff -upNr oldtree/drivers/media/dvb/frontends/mt312.c linux/drivers/media/dvb/frontends/mt312.c
--- oldtree/drivers/media/dvb/frontends/mt312.c	2008-04-14 22:20:08.000000000 -0300
+++ linux/drivers/media/dvb/frontends/mt312.c	2008-04-14 22:20:05.000000000 -0300
@@ -58,7 +58,7 @@ static int debug;
 #define MT312_PLL_CLK		10000000UL	/* 10 MHz */
 
 static int mt312_read(struct mt312_state *state, const enum mt312_reg_addr reg,
-		      void *buf, const size_t count)
+		      u8 *buf, const size_t count)
 {
 	int ret;
 	struct i2c_msg msg[2];
@@ -84,7 +84,7 @@ static int mt312_read(struct mt312_state
 		int i;
 		dprintk("R(%d):", reg & 0x7f);
 		for (i = 0; i < count; i++)
-			printk(" %02x", ((const u8 *) buf)[i]);
+			printk(" %02x", buf[i]);
 		printk("\n");
 	}
 
@@ -92,7 +92,7 @@ static int mt312_read(struct mt312_state
 }
 
 static int mt312_write(struct mt312_state *state, const enum mt312_reg_addr reg,
-		       const void *src, const size_t count)
+		       const u8 *src, const size_t count)
 {
 	int ret;
 	u8 buf[count + 1];
@@ -102,7 +102,7 @@ static int mt312_write(struct mt312_stat
 		int i;
 		dprintk("W(%d):", reg & 0x7f);
 		for (i = 0; i < count; i++)
-			printk(" %02x", ((const u8 *) src)[i]);
+			printk(" %02x", src[i]);
 		printk("\n");
 	}
 
@@ -463,7 +463,7 @@ static int mt312_read_snr(struct dvb_fro
 	int ret;
 	u8 buf[2];
 
-	ret = mt312_read(state, M_SNR_H, &buf, sizeof(buf));
+	ret = mt312_read(state, M_SNR_H, buf, sizeof(buf));
 	if (ret < 0)
 		return ret;
 
@@ -478,7 +478,7 @@ static int mt312_read_ucblocks(struct dv
 	int ret;
 	u8 buf[2];
 
-	ret = mt312_read(state, RS_UBC_H, &buf, sizeof(buf));
+	ret = mt312_read(state, RS_UBC_H, buf, sizeof(buf));
 	if (ret < 0)
 		return ret;
 

Re: [v4l-dvb-maintainer] no help text for DVB_TUNER_ITD1000

[Mauro Carvalho Chehab]

On Thu, 24 Apr 2008 14:08:21 -0700
Brandon Philips <bphilips@suse.de> wrote:

> On 17:28 Thu 24 Apr 2008, Mauro Carvalho Chehab wrote:
> > On Thu, 24 Apr 2008 23:22:57 +0300 Adrian Bunk <bunk@kernel.org> wrote:
> > > The DVB_TUNER_ITD1000 option introduced by
> > > commit 1881ee89e0fe03ac5bba9045acb3bea1818f9466
> > > (V4L/DVB (7571): mt312: Cleanup buffer variables of read/write functions)
> > > lacks a help text.
> > > 
> > > Please add a help text.
> > 
> > Thanks for pointing.
> > 
> > I just noticed and prepared a patch. I should soon add it to devel branch
> > at -git for people to review. 
> 
> How is adding this Kconfig related to the patch that Matthias posted?
> Once again, some very strange folding is happening as things are moving
> into git.
> 
> http://article.gmane.org/gmane.linux.drivers.dvb/41017/match=mt312+cleanup+buffer+variables+read+write+functions
> 
> vs.
> 
> http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commitdiff;h=1881ee89e0fe03ac5bba9045acb3bea1818f9466;hp=dbad108bdcb30629c850f5606949510da010a686

I didn't understood what happened. some chunks from patch 7569 were wrongly merged on 7571.

I suspect that it is a trouble on my local copy of the -git tree. git fsck is
generating 3434 lines of errors.

I've did a diff between the applied patch and the original ones. It is not easy
to compare the diffs manually, since file order changes, but it seems that the
other patches are ok.

I'll just drop this -git and create another replica.

Matthias, Patrick and others,

sorry for the mess.

Cheers,
Mauro

Re: [v4l-dvb-maintainer] no help text for DVB_TUNER_ITD1000

[Brandon Philips]

On 20:39 Thu 24 Apr 2008, Mauro Carvalho Chehab wrote:
> I've did a diff between the applied patch and the original ones. It is
> not easy to compare the diffs manually, since file order changes, but
> it seems that the other patches are ok.

interdiff can help find identical patches that just change file order.

Cheers,

	Brandon

Re: [v4l-dvb-maintainer] no help text for DVB_TUNER_ITD1000

[Mauro Carvalho Chehab]

On Thu, 24 Apr 2008 17:23:51 -0700
Brandon Philips <bphilips@suse.de> wrote:

> On 20:39 Thu 24 Apr 2008, Mauro Carvalho Chehab wrote:
> > I've did a diff between the applied patch and the original ones. It is
> > not easy to compare the diffs manually, since file order changes, but
> > it seems that the other patches are ok.
> 
> interdiff can help find identical patches that just change file order.

Very useful. 

It confirmed that the only two patches with problems are:

v4l_dvb_hg_7571_mt312_cleanup_buffer_variables_of_read_write_functions.patch:
--- b/drivers/media/dvb/frontends/Kconfig
+++ a/drivers/media/dvb/frontends/Kconfig

-config DVB_TUNER_ITD1000
-       tristate "Integrant ITD1000 Zero IF tuner for DVB-S/DSS"
-       depends on DVB_CORE && I2C
-       default m if DVB_FE_CUSTOMISE
-
 comment "Miscellaneous devices"
--- b/drivers/media/dvb/frontends/Makefile
+++ a/drivers/media/dvb/frontends/Makefile
 obj-$(CONFIG_DVB_TUNER_XC5000) += xc5000.o
-obj-$(CONFIG_DVB_TUNER_ITD1000) += itd1000.o

and v4l_dvb_hg_7569_added_support_for_skystar2_rev2_7_and_itd1000_dvb_s_tuner.patch:

only in patch2:
--- oldtree/drivers/media/dvb/frontends/Kconfig 2008-04-14 22:19:41.000000000 -0300
+++ linux/drivers/media/dvb/frontends/Kconfig   2008-04-14 22:19:38.000000000 -0300

+config DVB_TUNER_ITD1000
+       tristate "Integrant ITD1000 Zero IF tuner for DVB-S/DSS"
+       depends on DVB_CORE && I2C
+       default m if DVB_FE_CUSTOMISE
+
 comment "Miscellaneous devices"
only in patch2:
--- oldtree/drivers/media/dvb/frontends/Makefile        2008-04-14 22:19:41.000000000 -0300
+++ linux/drivers/media/dvb/frontends/Makefile  2008-04-14 22:19:38.000000000 -0300
 obj-$(CONFIG_DVB_TUNER_XC5000) += xc5000.o
+obj-$(CONFIG_DVB_TUNER_ITD1000) += itd1000.o

I can't understand what happened by looking on my procedure. It really seems to
be some corruption on -git, maybe due to stgit porcelain.


Cheers,
Mauro