public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Arjan van de Ven <arjan@infradead.org>,
	Christoph Hellwig <hch@infradead.org>,
	Sam Ravnborg <sam@ravnborg.org>, Adrian Bunk <bunk@kernel.org>,
	linux arch <linux-arch@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>
Subject: Re: [PATCH] prepare kconfig inline optimization for all architectures
Date: Mon, 28 Apr 2008 01:41:10 +0200	[thread overview]
Message-ID: <20080427234110.GA14679@elte.hu> (raw)
In-Reply-To: <alpine.LFD.1.10.0804271634490.3119@woody.linux-foundation.org>


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Sun, 27 Apr 2008, Arjan van de Ven wrote:
> > 
> > (actually, other than some obscure commandline options, the only 
> > sane way to avoid gcc doing this too agressive is using -Os)
> 
> Well, CC_OPTIMIZE_FOR_SIZE has been defaulting to 'y' for a *loong* 
> time, but it's hidden behind a EXPERIMENTAL (unless you were on some 
> embedded architectures), so many people won't see it.
> 
> Perhaps it is time to remove the EXPERIMENTAL? I think the gcc 
> warnings were mostly bogus - it's not as if there haven't been 
> compiler bugs without -Os too..

i was wondering about that when doing the OPTIMIZE_INLINING change - 
lets do something like the patch below?

	Ingo

-------------->
Subject: make CC_OPTIMIZE_FOR_SIZE non-experimental
From: Ingo Molnar <mingo@elte.hu>
Date: Mon Apr 28 01:39:43 CEST 2008

this option has been the default on a wide range of distributions
for a long time - time to make it non-experimental.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 init/Kconfig |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Index: linux-x86.q/init/Kconfig
===================================================================
--- linux-x86.q.orig/init/Kconfig
+++ linux-x86.q/init/Kconfig
@@ -496,16 +496,12 @@ source "usr/Kconfig"
 endif
 
 config CC_OPTIMIZE_FOR_SIZE
-	bool "Optimize for size (Look out for broken compilers!)"
+	bool "Optimize for size"
 	default y
-	depends on ARM || H8300 || SUPERH || EXPERIMENTAL
 	help
 	  Enabling this option will pass "-Os" instead of "-O2" to gcc
 	  resulting in a smaller kernel.
 
-	  WARNING: some versions of gcc may generate incorrect code with this
-	  option.  If problems are observed, a gcc upgrade may be needed.
-
 	  If unsure, say N.
 
 config SYSCTL

  reply	other threads:[~2008-04-27 23:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-27 10:51 [PATCH] prepare kconfig inline optimization for all architectures Sam Ravnborg
2008-04-27 11:31 ` Adrian Bunk
2008-04-27 11:56   ` Sam Ravnborg
2008-04-27 12:36     ` Ingo Molnar
2008-04-27 12:49       ` Ingo Molnar
2008-04-27 17:06   ` Linus Torvalds
2008-04-27 17:22     ` Adrian Bunk
2008-04-27 17:32       ` Linus Torvalds
2008-04-27 17:47         ` Adrian Bunk
2008-04-27 18:00           ` Christoph Hellwig
2008-04-27 18:09             ` Sam Ravnborg
2008-04-27 18:14               ` Christoph Hellwig
2008-04-27 18:24                 ` Linus Torvalds
2008-04-27 18:32                   ` Christoph Hellwig
2008-04-27 19:36                   ` Ingo Molnar
2008-04-27 19:49                     ` Adrian Bunk
2008-04-27 23:26                   ` Arjan van de Ven
2008-04-27 23:36                     ` Linus Torvalds
2008-04-27 23:41                       ` Ingo Molnar [this message]
2008-04-27 18:31                 ` Sam Ravnborg
2008-04-27 18:36                   ` Christoph Hellwig
2008-04-27 18:11           ` Linus Torvalds
2008-04-27 18:25             ` Christoph Hellwig
2008-04-27 18:30               ` Linus Torvalds
2008-04-27 18:41             ` Adrian Bunk
2008-04-27 18:57               ` Linus Torvalds
2008-04-27 20:51           ` Mike Galbraith
2008-04-27 17:57         ` Christoph Hellwig
2008-04-27 17:40       ` Matthew Wilcox
2008-04-27 17:59         ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080427234110.GA14679@elte.hu \
    --to=mingo@elte.hu \
    --cc=arjan@infradead.org \
    --cc=bunk@kernel.org \
    --cc=davem@davemloft.net \
    --cc=hch@infradead.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox