From: Pavel Machek <pavel@suse.cz>
To: Ingo Molnar <mingo@elte.hu>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
macro@ds2.pg.gda.pl
Subject: i8259.c: remove #ifdefs around includes
Date: Wed, 21 May 2008 11:47:24 +0200 [thread overview]
Message-ID: <20080521094724.GC12763@elf.ucw.cz> (raw)
In-Reply-To: <20080520204750.GA31409@elte.hu>
Remove #ifdefs around includes; including too much should be always
safe.
Signed-off-by: Pavel Machek <pavel@suse.cz>
---
commit 06f12eb6da33da70dbdccbee5a687d5353782e1d
tree 62b9b1a785bbc5a9daa22512ec95601d54aa004d
parent 44b4ec2247971ba1a1906752208182146fc5974c
author Pavel <pavel@amd.ucw.cz> Wed, 21 May 2008 11:46:46 +0200
committer Pavel <pavel@amd.ucw.cz> Wed, 21 May 2008 11:46:46 +0200
arch/x86/kernel/i8259.c | 11 -----------
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c
index 2decba6..8b7eb0c 100644
--- a/arch/x86/kernel/i8259.c
+++ b/arch/x86/kernel/i8259.c
@@ -1,14 +1,10 @@
-#ifdef CONFIG_X86_64
#include <linux/linkage.h>
-#endif /* CONFIG_X86_64 */
#include <linux/errno.h>
#include <linux/signal.h>
#include <linux/sched.h>
#include <linux/ioport.h>
#include <linux/interrupt.h>
-#ifdef CONFIG_X86_64
#include <linux/timex.h>
-#endif /* CONFIG_X86_64 */
#include <linux/slab.h>
#include <linux/random.h>
#include <linux/init.h>
@@ -16,24 +12,17 @@ #include <linux/kernel_stat.h>
#include <linux/sysdev.h>
#include <linux/bitops.h>
-#ifdef CONFIG_X86_64
#include <asm/acpi.h>
-#endif /* CONFIG_X86_64 */
#include <asm/atomic.h>
#include <asm/system.h>
#include <asm/io.h>
-#ifndef CONFIG_X86_64
#include <asm/timer.h>
-#else /* CONFIG_X86_64 */
#include <asm/hw_irq.h>
-#endif /* CONFIG_X86_64 */
#include <asm/pgtable.h>
#include <asm/delay.h>
#include <asm/desc.h>
#include <asm/apic.h>
-#ifndef CONFIG_X86_64
#include <asm/arch_hooks.h>
-#endif /* ! CONFIG_X86_64 */
#include <asm/i8259.h>
/*
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-05-21 9:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 15:15 Unify common parts of i8259.c Pavel Machek
2008-05-20 20:47 ` Ingo Molnar
2008-05-20 22:35 ` Pavel Machek
2008-05-21 9:44 ` Automatical unification " Pavel Machek
2008-05-22 18:30 ` Thomas Gleixner
2008-05-22 20:19 ` Pavel Machek
2008-05-22 20:30 ` Sam Ravnborg
2008-05-22 22:32 ` i8259: fix final uglyness Pavel Machek
2008-05-27 8:46 ` Thomas Gleixner
2008-05-27 8:55 ` Pavel Machek
2008-05-27 9:01 ` Thomas Gleixner
2008-05-28 10:42 ` Pavel Machek
2008-06-02 9:43 ` Ingo Molnar
2008-05-21 9:47 ` Pavel Machek [this message]
2008-05-21 9:52 ` i8259.c: remove trivial ifdefs Pavel Machek
2008-05-21 9:57 ` i8259: cleanup codingstyle Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521094724.GC12763@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@ds2.pg.gda.pl \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox