From: Pavel Machek <pavel@suse.cz>
To: Ingo Molnar <mingo@elte.hu>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
macro@ds2.pg.gda.pl
Subject: i8259.c: remove trivial ifdefs
Date: Wed, 21 May 2008 11:52:52 +0200 [thread overview]
Message-ID: <20080521095252.GD12763@elf.ucw.cz> (raw)
In-Reply-To: <20080520204750.GA31409@elte.hu>
Remove #ifdefs where the only difference is formatting of comments.
Signed-off-by: Pavel Machek <pavel@suse.cz>
---
commit 800e1add46a2686995af98432a7971150318676d
tree 5daa71306ceb60b0fb7e5707ec4d9701c06197de
parent 06f12eb6da33da70dbdccbee5a687d5353782e1d
author Pavel <pavel@amd.ucw.cz> Wed, 21 May 2008 11:52:11 +0200
committer Pavel <pavel@amd.ucw.cz> Wed, 21 May 2008 11:52:11 +0200
arch/x86/kernel/i8259.c | 20 +++-----------------
1 files changed, 3 insertions(+), 17 deletions(-)
diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c
index 8b7eb0c..433e49e 100644
--- a/arch/x86/kernel/i8259.c
+++ b/arch/x86/kernel/i8259.c
@@ -175,24 +175,14 @@ handle_real_irq:
if (irq & 8) {
inb(PIC_SLAVE_IMR); /* DUMMY - (do we need this?) */
outb(cached_slave_mask, PIC_SLAVE_IMR);
-#ifndef CONFIG_X86_64
- outb(0x60+(irq&7),PIC_SLAVE_CMD);/* 'Specific EOI' to slave */
- outb(0x60+PIC_CASCADE_IR,PIC_MASTER_CMD); /* 'Specific EOI' to master-IRQ2 */
-#else /* CONFIG_X86_64 */
/* 'Specific EOI' to slave */
- outb(0x60+(irq&7),PIC_SLAVE_CMD);
+ outb(0x60+(irq&7), PIC_SLAVE_CMD);
/* 'Specific EOI' to master-IRQ2 */
- outb(0x60+PIC_CASCADE_IR,PIC_MASTER_CMD);
-#endif /* CONFIG_X86_64 */
+ outb(0x60+PIC_CASCADE_IR, PIC_MASTER_CMD);
} else {
inb(PIC_MASTER_IMR); /* DUMMY - (do we need this?) */
outb(cached_master_mask, PIC_MASTER_IMR);
-#ifndef CONFIG_X86_64
- outb(0x60+irq,PIC_MASTER_CMD); /* 'Specific EOI to master */
-#else /* CONFIG_X86_64 */
- /* 'Specific EOI' to master */
- outb(0x60+irq,PIC_MASTER_CMD);
-#endif /* CONFIG_X86_64 */
+ outb(0x60+irq, PIC_MASTER_CMD); /* 'Specific EOI to master */
}
spin_unlock_irqrestore(&i8259A_lock, flags);
return;
@@ -215,12 +205,8 @@ spurious_8259A_irq:
* lets ACK and report it. [once per IRQ]
*/
if (!(spurious_irq_mask & irqmask)) {
-#ifndef CONFIG_X86_64
- printk(KERN_DEBUG "spurious 8259A interrupt: IRQ%d.\n", irq);
-#else /* CONFIG_X86_64 */
printk(KERN_DEBUG
"spurious 8259A interrupt: IRQ%d.\n", irq);
-#endif /* CONFIG_X86_64 */
spurious_irq_mask |= irqmask;
}
atomic_inc(&irq_err_count);
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-05-21 9:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 15:15 Unify common parts of i8259.c Pavel Machek
2008-05-20 20:47 ` Ingo Molnar
2008-05-20 22:35 ` Pavel Machek
2008-05-21 9:44 ` Automatical unification " Pavel Machek
2008-05-22 18:30 ` Thomas Gleixner
2008-05-22 20:19 ` Pavel Machek
2008-05-22 20:30 ` Sam Ravnborg
2008-05-22 22:32 ` i8259: fix final uglyness Pavel Machek
2008-05-27 8:46 ` Thomas Gleixner
2008-05-27 8:55 ` Pavel Machek
2008-05-27 9:01 ` Thomas Gleixner
2008-05-28 10:42 ` Pavel Machek
2008-06-02 9:43 ` Ingo Molnar
2008-05-21 9:47 ` i8259.c: remove #ifdefs around includes Pavel Machek
2008-05-21 9:52 ` Pavel Machek [this message]
2008-05-21 9:57 ` i8259: cleanup codingstyle Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521095252.GD12763@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@ds2.pg.gda.pl \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox