From: Pavel Machek <pavel@suse.cz>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@elte.hu>,
kernel list <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
macro@ds2.pg.gda.pl
Subject: Re: Automatical unification of i8259.c
Date: Thu, 22 May 2008 22:19:25 +0200 [thread overview]
Message-ID: <20080522201925.GA14124@elf.ucw.cz> (raw)
In-Reply-To: <alpine.LFD.1.10.0805222030050.3295@apollo.tec.linutronix.de>
Hi!
> > Make conversion of i8259 very mechanical -- i8259 was generated by
> > diff -D, with too different parts left in i8259_32 and
> > i8259_64.c. Only "by hand" changes were removal of #ifdef from middle
> > of the comment (prevented compilation) and removal of one static to
> > allow splitting into files.
> >
> > Of course, it will need some cleanups now, and those will follow.
>
> Applied. Thanks,
Does that mean that followup patches are in, too? This is really too
ugly to live alone ;-).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-05-22 20:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 15:15 Unify common parts of i8259.c Pavel Machek
2008-05-20 20:47 ` Ingo Molnar
2008-05-20 22:35 ` Pavel Machek
2008-05-21 9:44 ` Automatical unification " Pavel Machek
2008-05-22 18:30 ` Thomas Gleixner
2008-05-22 20:19 ` Pavel Machek [this message]
2008-05-22 20:30 ` Sam Ravnborg
2008-05-22 22:32 ` i8259: fix final uglyness Pavel Machek
2008-05-27 8:46 ` Thomas Gleixner
2008-05-27 8:55 ` Pavel Machek
2008-05-27 9:01 ` Thomas Gleixner
2008-05-28 10:42 ` Pavel Machek
2008-06-02 9:43 ` Ingo Molnar
2008-05-21 9:47 ` i8259.c: remove #ifdefs around includes Pavel Machek
2008-05-21 9:52 ` i8259.c: remove trivial ifdefs Pavel Machek
2008-05-21 9:57 ` i8259: cleanup codingstyle Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080522201925.GA14124@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@ds2.pg.gda.pl \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox