GPE storm detected, disabling EC GPE

GPE storm detected, disabling EC GPE

[Justin Mattock]

FWIW I noticed a post where the person had changed 5 to 20, and it
seemed to work for them;
So with that in mind I decide to give that a go, here is the location:
drivers/acpi/ec.c
@@ -527,47 +488,51 @@ static u32 acpi_ec_gpe_handler(void *data)
 {
        acpi_status status = AE_OK;
        struct acpi_ec *ec = data;
       u8 state = acpi_ec_read_status(ec);

        pr_debug(PREFIX "~~~> interrupt\n");
       atomic_inc(&ec->irq_count);
-       if (atomic_read(&ec->irq_count) > 5) {
+       if (atomic_read(&ec->irq_count) > 20) {
               pr_err(PREFIX "GPE storm detected, disabling EC GPE\n");
               ec_switch_to_poll_mode(ec);
               goto end;
       }

Now I don't know if this will work for other brands, but for
me(Macbook Pro ATI chipset) I have not received the
GPE storm detected, disabling EC GPE message, but it's only been an
hour, maybe after two or three this might appear.
Also is this good or bad to set 5 to 20 for the system?
regards;

-- 
Justin P. Mattock

Re: GPE storm detected, disabling EC GPE

[Andrew Morton]

On Thu, 5 Jun 2008 21:01:55 +0000
"Justin Mattock" <justinmattock@gmail.com> wrote:

> FWIW I noticed a post where the person had changed 5 to 20, and it
> seemed to work for them;
> So with that in mind I decide to give that a go, here is the location:
> drivers/acpi/ec.c
> @@ -527,47 +488,51 @@ static u32 acpi_ec_gpe_handler(void *data)
>  {
>         acpi_status status = AE_OK;
>         struct acpi_ec *ec = data;
>        u8 state = acpi_ec_read_status(ec);
> 
>         pr_debug(PREFIX "~~~> interrupt\n");
>        atomic_inc(&ec->irq_count);
> -       if (atomic_read(&ec->irq_count) > 5) {
> +       if (atomic_read(&ec->irq_count) > 20) {
>                pr_err(PREFIX "GPE storm detected, disabling EC GPE\n");
>                ec_switch_to_poll_mode(ec);
>                goto end;
>        }
> 
> Now I don't know if this will work for other brands, but for
> me(Macbook Pro ATI chipset) I have not received the
> GPE storm detected, disabling EC GPE message, but it's only been an
> hour, maybe after two or three this might appear.
> Also is this good or bad to set 5 to 20 for the system?
> regards;

We've had a few reports of this GPE-storm problem and I've rather lost
track of what's happening.  Has anyone looked into it?

If not, do we have a bugzilla report where we can work on this?

Thanks.

Re: GPE storm detected, disabling EC GPE

[Rafael J. Wysocki]

On Monday, 30 of June 2008, Andrew Morton wrote:
> On Thu, 5 Jun 2008 21:01:55 +0000
> "Justin Mattock" <justinmattock@gmail.com> wrote:
> 
> > FWIW I noticed a post where the person had changed 5 to 20, and it
> > seemed to work for them;
> > So with that in mind I decide to give that a go, here is the location:
> > drivers/acpi/ec.c
> > @@ -527,47 +488,51 @@ static u32 acpi_ec_gpe_handler(void *data)
> >  {
> >         acpi_status status = AE_OK;
> >         struct acpi_ec *ec = data;
> >        u8 state = acpi_ec_read_status(ec);
> > 
> >         pr_debug(PREFIX "~~~> interrupt\n");
> >        atomic_inc(&ec->irq_count);
> > -       if (atomic_read(&ec->irq_count) > 5) {
> > +       if (atomic_read(&ec->irq_count) > 20) {
> >                pr_err(PREFIX "GPE storm detected, disabling EC GPE\n");
> >                ec_switch_to_poll_mode(ec);
> >                goto end;
> >        }
> > 
> > Now I don't know if this will work for other brands, but for
> > me(Macbook Pro ATI chipset) I have not received the
> > GPE storm detected, disabling EC GPE message, but it's only been an
> > hour, maybe after two or three this might appear.
> > Also is this good or bad to set 5 to 20 for the system?
> > regards;
> 
> We've had a few reports of this GPE-storm problem and I've rather lost
> track of what's happening.  Has anyone looked into it?

Yes, the problem is still being worked on, AFAICS.

> If not, do we have a bugzilla report where we can work on this?

There's a bugzilla entry at http://bugzilla.kernel.org/show_bug.cgi?id=10724 .

Thanks,
Rafael

Re: GPE storm detected, disabling EC GPE

[Justin Mattock]

On Mon, Jun 30, 2008 at 7:59 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Monday, 30 of June 2008, Andrew Morton wrote:
>> On Thu, 5 Jun 2008 21:01:55 +0000
>> "Justin Mattock" <justinmattock@gmail.com> wrote:
>>
>> > FWIW I noticed a post where the person had changed 5 to 20, and it
>> > seemed to work for them;
>> > So with that in mind I decide to give that a go, here is the location:
>> > drivers/acpi/ec.c
>> > @@ -527,47 +488,51 @@ static u32 acpi_ec_gpe_handler(void *data)
>> >  {
>> >         acpi_status status = AE_OK;
>> >         struct acpi_ec *ec = data;
>> >        u8 state = acpi_ec_read_status(ec);
>> >
>> >         pr_debug(PREFIX "~~~> interrupt\n");
>> >        atomic_inc(&ec->irq_count);
>> > -       if (atomic_read(&ec->irq_count) > 5) {
>> > +       if (atomic_read(&ec->irq_count) > 20) {
>> >                pr_err(PREFIX "GPE storm detected, disabling EC GPE\n");
>> >                ec_switch_to_poll_mode(ec);
>> >                goto end;
>> >        }
>> >
>> > Now I don't know if this will work for other brands, but for
>> > me(Macbook Pro ATI chipset) I have not received the
>> > GPE storm detected, disabling EC GPE message, but it's only been an
>> > hour, maybe after two or three this might appear.
>> > Also is this good or bad to set 5 to 20 for the system?
>> > regards;
>>
>> We've had a few reports of this GPE-storm problem and I've rather lost
>> track of what's happening.  Has anyone looked into it?
>
> Yes, the problem is still being worked on, AFAICS.
>
>> If not, do we have a bugzilla report where we can work on this?
>
> There's a bugzilla entry at http://bugzilla.kernel.org/show_bug.cgi?id=10724 .
>
> Thanks,
> Rafael
>

Hello; I must be honest I'm not real sure on what Is happening with
this. The above: if (atomic_read(&ec->irq_count) > 20) {
just prolongs the message from going off(doesn't deal with the main problem).
Now it is interesting from over here with a macbook, due to this message having
to deal with the battery(if that's the case) i.g. removing the battery
results in no gpe storm being detected(or not too many interrupts), on
the contrary the other laptops acer or whatever was experiencing the
same issue, was in something completely different. Now just out of
curiosity
I was thinking back to when this wasn't happening and it must have
been around april or so, after looking at the activity with acpi the
only
real scenario I saw that might have led to this would be:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=cf7acfab032ff262f42954328cdfd20a5d9aaaac
/ but like I said out of curiosity maybe this was what might be
triggering
the interrupts to fire this message off, but could be something
completely in an other location.
As for right now I'm open to any ideas.
regards;

-- 
Justin P. Mattock