Re: [PATCH -v3 0/8] file notification: fsnotify a unified file notification backend

[Andrew Morton <akpm@linux-foundation.org>]

On Tue, 25 Nov 2008 12:20:51 -0500
Eric Paris <eparis@redhat.com> wrote:

> This series only reimplements dnotify using the new fsnotify backend.  If
> accepted I will do the work to port inotify as well.  Currently struct inode
> goes from:
> 
> #ifdef CONFIG_DNOTIFY
>        unsigned long           i_dnotify_mask; /* Directory notify events */
>        struct dnotify_struct   *i_dnotify; /* for directory notifications */
> #endif
> 
> to:
> #ifdef CONFIG_FSNOTIFY
>        unsigned long           i_fsnotify_mask; /* all events this inode cares about */
>        struct list_head        i_fsnotify_mark_entries; /* fsnotify mark entries */
>        spinlock_t              i_fsnotify_lock; /* protect the entries list */
> #endif
> 
> so the inode still grows, but the inotify fields will be dropped as well
> resulting in a smaller struct inode.  These are all the fields fanotify will
> want as well.

Did you consider using i_lock to protect that list?  Its mandate is "an
innermost lock which protects fields within the inode".

> 29 files changed, 3100 insertions(+), 1977 deletions(-)

	if (code > code_reviewers)
		fix();

but how?